From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] conntrackd: resolve a compiler error Date: Thu, 31 May 2012 16:15:03 +0200 Message-ID: <20120531141503.GA1340@1984> References: <1338465797-9797-1-git-send-email-jengelh@inai.de> <1338465797-9797-2-git-send-email-jengelh@inai.de> <20120531131945.GA961@1984> <20120531133114.GA10522@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , netfilter-devel@vger.kernel.org To: Jan Engelhardt Return-path: Received: from mail.us.es ([193.147.175.20]:57826 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757496Ab2EaOPI (ORCPT ); Thu, 31 May 2012 10:15:08 -0400 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, May 31, 2012 at 03:50:11PM +0200, Jan Engelhardt wrote: > > On Thursday 2012-05-31 15:31, Florian Westphal wrote: > >> > > >> > CC parse.o > >> > parse.c: In function 'msg2ct': > >> > parse.c:258:34: error: 'NULL' undeclared (first use in this function) > >> > parse.c:258:34: note: each undeclared identifier is reported only once for each function it appears in > >> > parse.c: In function 'msg2exp': > >> > parse.c:438:16: error: 'NULL' undeclared (first use in this function) > >> > >> Similar patch was already applied. > >> > >> http://git.netfilter.org/cgi-bin/gitweb.cgi?p=conntrack-tools.git;a=commit;h=d44489648c1a56d543a84bbebe455227bb25cf34 > > > >NULL is defined in stddef.h, stdlib.h does not necessarily pull that > >header in, too. > > I believe that the C standard defines that NULL has to become available > through (at least) stdio.h. Though wikipedia may not always be authoritative, > I will use it as an excuse now: http://en.wikipedia.org/wiki/Stdio.h > > So if #include makes NULL available, good for glibc, but it > may not satisfy certain implementations. As soon the compilation works, I'll be happy to use the more precise header. Send me one patch upon the current git HEAD, I'll take it.