From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Wensong Zhang <wensong@linux-vs.org>,
Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] netfilter: ipvs: fix dst leak in __ip_vs_addr_is_local_v6
Date: Mon, 25 Jun 2012 15:11:30 +0200 [thread overview]
Message-ID: <20120625131130.GB12597@1984> (raw)
In-Reply-To: <1340611103.10893.14.camel@edumazet-glaptop>
On Mon, Jun 25, 2012 at 09:58:23AM +0200, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> After call to ip6_route_output() we must release dst or we leak it.
>
> Also should test dst->error, as ip6_route_output() never returns NULL.
>
> Use boolean while we are at it.
Applied, thanks Eric.
prev parent reply other threads:[~2012-06-25 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 7:58 [PATCH] netfilter: ipvs: fix dst leak in __ip_vs_addr_is_local_v6 Eric Dumazet
2012-06-25 13:11 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625131130.GB12597@1984 \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).