From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: ipvs: fix dst leak in __ip_vs_addr_is_local_v6 Date: Mon, 25 Jun 2012 15:11:30 +0200 Message-ID: <20120625131130.GB12597@1984> References: <1340611103.10893.14.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, netdev , Wensong Zhang , Simon Horman , Julian Anastasov , David Miller To: Eric Dumazet Return-path: Content-Disposition: inline In-Reply-To: <1340611103.10893.14.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Mon, Jun 25, 2012 at 09:58:23AM +0200, Eric Dumazet wrote: > From: Eric Dumazet > > After call to ip6_route_output() we must release dst or we leak it. > > Also should test dst->error, as ip6_route_output() never returns NULL. > > Use boolean while we are at it. Applied, thanks Eric.