netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
	netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 1/1] netfilter: make net/stat/nf_conntrack procfs available again
Date: Wed, 27 Jun 2012 13:20:49 +0200	[thread overview]
Message-ID: <20120627112049.GA2939@breakpoint.cc> (raw)
In-Reply-To: <20120627110147.GA25605@1984>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Mon, Jun 25, 2012 at 04:02:05PM +0200, Florian Westphal wrote:
> > partially reverts commit 54b07dca68557b0952585b5f4834cd0dd86eba35
> > (netfilter: provide config option to disable ancient procfs parts).
> > 
> > Problem is that this also disabled net/stat/nf_conntrack, which
> > is useful for diagnosing certain conntrack-related issues; and there
> > are currently no other means to obtain these statistics from userspace.
> >
> > (conntrack-tools "conntrack -S" uses the proc interface, too...)
> 
> I can pass the following patch to David. It implements the missing
> code in ctnetlink to dump the statistics. Thus, conntrack doesn't use
> any /proc interface anymore (the changes to conntrack still pending).

Thanks, that would be fine, too.

> If you're OK with it, I'll integrate this in a backward compatible way
> (first try to use netlink, if not available, use /proc).

Sounds good.

> Still, I think that passing this to current may be useful. Although
> you can workaround this by enable that option. What do you prefer?

Ignore my patch.  In the meantime people can NF_CONNTRACK_PROCFS=y;
we just have to wait a bit (e.g. a year) before killing the nfct
proc code completely.

  reply	other threads:[~2012-06-27 11:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 14:02 [PATCH 1/1] netfilter: make net/stat/nf_conntrack procfs available again Florian Westphal
2012-06-27 11:01 ` Pablo Neira Ayuso
2012-06-27 11:20   ` Florian Westphal [this message]
2012-06-27 15:23     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627112049.GA2939@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).