netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] nfnetlink: Unlock a previously locked rcu_read in nfnetlink_rcv_msg
Date: Fri, 29 Jun 2012 13:13:39 +0200	[thread overview]
Message-ID: <20120629111339.GB15598@1984> (raw)
In-Reply-To: <1340890210.13187.100.camel@edumazet-glaptop>

On Thu, Jun 28, 2012 at 03:30:10PM +0200, Eric Dumazet wrote:
> On Thu, 2012-06-28 at 15:57 +0300, Tomasz Bursztyka wrote:
> > Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
> > ---
> >  net/netfilter/nfnetlink.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
> > index 4acdd76..a6366ae 100644
> > --- a/net/netfilter/nfnetlink.c
> > +++ b/net/netfilter/nfnetlink.c
> > @@ -169,8 +169,10 @@ replay:
> >  
> >  		err = nla_parse(cda, ss->cb[cb_id].attr_count,
> >  				attr, attrlen, ss->cb[cb_id].policy);
> > -		if (err < 0)
> > +		if (err < 0) {
> > +			rcu_read_unlock();
> >  			return err;
> > +		}
> >  
> >  		if (nc->call_rcu) {
> >  			err = nc->call_rcu(net->nfnl, skb, nlh,
> 
> Nice catch, thanks.
> 
> Please someone add in changelog to ease stable team work :
> 
> Bug added in commit 6b75e3e8d664a9a (netfilter: nfnetlink: add RCU in
> nfnetlink_rcv_msg())
> 
> Acked-by: Eric Dumazet <edumazet@google.com>

Applied, thanks.

      reply	other threads:[~2012-06-29 11:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 12:57 [PATCH 0/3] Nfnetlink and ipset fixes Tomasz Bursztyka
2012-06-28 12:57 ` [PATCH 1/3] nfnetlink: Check callbacks before using those in nfnetlink_rcv_msg Tomasz Bursztyka
2012-06-29 11:15   ` Pablo Neira Ayuso
2012-06-29 19:03     ` Jan Engelhardt
2012-06-30  8:54       ` Florian Westphal
2012-07-04 20:54         ` Pablo Neira Ayuso
2012-06-28 12:57 ` [PATCH 2/3] ipset: Handle properly an IPSET_CMD_NONE Tomasz Bursztyka
2012-06-28 14:40   ` Jozsef Kadlecsik
2012-06-29 11:13     ` Pablo Neira Ayuso
2012-06-28 12:57 ` [PATCH 3/3] nfnetlink: Unlock a previously locked rcu_read in nfnetlink_rcv_msg Tomasz Bursztyka
2012-06-28 13:30   ` Eric Dumazet
2012-06-29 11:13     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120629111339.GB15598@1984 \
    --to=pablo@netfilter.org \
    --cc=eric.dumazet@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=tomasz.bursztyka@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).