* [patch -next] netfilter: use kfree_skb() not kfree()
@ 2012-06-30 11:48 Dan Carpenter
2012-07-01 0:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-06-30 11:48 UTC (permalink / raw)
To: Bart De Schuymer
Cc: coreteam, netdev, bridge, kernel-janitors, David S. Miller,
netfilter, netfilter-devel, Stephen Hemminger, Pablo Neira Ayuso
This was should be a kfree_skb() here to free the sk_buff pointer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c
index 1bd1732..dfbb019 100644
--- a/net/bridge/netfilter/ebt_ulog.c
+++ b/net/bridge/netfilter/ebt_ulog.c
@@ -156,7 +156,7 @@ static void ebt_ulog_packet(unsigned int hooknr, const struct sk_buff *skb,
nlh = nlmsg_put(ub->skb, 0, ub->qlen, 0,
size - NLMSG_ALIGN(sizeof(*nlh)), 0);
if (!nlh) {
- kfree(ub->skb);
+ kfree_skb(ub->skb);
ub->skb = NULL;
goto unlock;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch -next] netfilter: use kfree_skb() not kfree()
2012-06-30 11:48 [patch -next] netfilter: use kfree_skb() not kfree() Dan Carpenter
@ 2012-07-01 0:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-01 0:27 UTC (permalink / raw)
To: dan.carpenter
Cc: netfilter, coreteam, netdev, bridge, kernel-janitors,
bart.de.schuymer, netfilter-devel, shemminger, pablo
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 30 Jun 2012 14:48:53 +0300
> This was should be a kfree_skb() here to free the sk_buff pointer.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
My bad, applied, thanks Dan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-01 0:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-30 11:48 [patch -next] netfilter: use kfree_skb() not kfree() Dan Carpenter
2012-07-01 0:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).