From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bart De Schuymer <bart.de.schuymer@pandora.be>
Cc: coreteam@netfilter.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org,
Stephen Hemminger <shemminger@vyatta.com>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: [patch -next] netfilter: use kfree_skb() not kfree()
Date: Sat, 30 Jun 2012 14:48:53 +0300 [thread overview]
Message-ID: <20120630114853.GA22767@elgon.mountain> (raw)
This was should be a kfree_skb() here to free the sk_buff pointer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c
index 1bd1732..dfbb019 100644
--- a/net/bridge/netfilter/ebt_ulog.c
+++ b/net/bridge/netfilter/ebt_ulog.c
@@ -156,7 +156,7 @@ static void ebt_ulog_packet(unsigned int hooknr, const struct sk_buff *skb,
nlh = nlmsg_put(ub->skb, 0, ub->qlen, 0,
size - NLMSG_ALIGN(sizeof(*nlh)), 0);
if (!nlh) {
- kfree(ub->skb);
+ kfree_skb(ub->skb);
ub->skb = NULL;
goto unlock;
}
next reply other threads:[~2012-06-30 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 11:48 Dan Carpenter [this message]
2012-07-01 0:27 ` [patch -next] netfilter: use kfree_skb() not kfree() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120630114853.GA22767@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=bart.de.schuymer@pandora.be \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).