From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Hans Schillstrom <hans@schillstrom.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] extensions: add HMARK target
Date: Thu, 12 Jul 2012 17:29:47 +0200 [thread overview]
Message-ID: <20120712152947.GA18341@1984> (raw)
In-Reply-To: <tqndgm6.047f943bd7060a4c2b179885c2c22c50@obelix.schillstrom.com>
On Thu, Jul 12, 2012 at 09:34:45AM +0200, Hans Schillstrom wrote:
> Hi Pablo
> [snip]
> +static void HMARK_check(struct xt_fcheck_call *cb)
> >+{
> >+ if (!(cb->xflags & (1 << O_HMARK_MODULUS)))
> >+ xtables_error(PARAMETER_PROBLEM, "--hmark-mod is mandatory");
> >+ if (!(cb->xflags & (1 << O_HMARK_RND)))
> >+ xtables_error(PARAMETER_PROBLEM, "--hmark-rnd is mandatory");
>
> I don't think rnd should be mandatory, a default value is enough.
> offset however should be mandatory.
As I said, parameters that are not set will likely not be set by
users. If default value for random, the easier it will be for an
attacker to direct all flows to the same target.
I'll be OK to make --hmark-offset mandatory, BTW.
next prev parent reply other threads:[~2012-07-12 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 7:34 [PATCH 2/2] extensions: add HMARK target Hans Schillstrom
2012-07-12 15:29 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-14 22:53 Re[2]: " Hans Schillstrom
2012-07-16 12:22 ` Pablo Neira Ayuso
2012-07-12 7:29 Hans Schillstrom
2012-07-10 23:17 [PATCH 0/2] revamped HMARK extension pablo
2012-07-10 23:17 ` [PATCH 2/2] extensions: add HMARK target pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712152947.GA18341@1984 \
--to=pablo@netfilter.org \
--cc=hans@schillstrom.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).