From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/4] netfilter: xt_recent: remove ip_list_hash_size parameter
Date: Thu, 12 Jul 2012 17:42:10 +0200 [thread overview]
Message-ID: <20120712154210.GC18793@1984> (raw)
In-Reply-To: <1341964350-13809-2-git-send-email-jengelh@inai.de>
On Wed, Jul 11, 2012 at 01:52:27AM +0200, Jan Engelhardt wrote:
> This module parameter has no effect, since the user-specified value is
> overriden by the init function anyway.
My only concern with this is to break existing configuration that sets
that module parameter.
I wonder if it's useful to fix this module parameter to make it work
instead.
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> net/netfilter/xt_recent.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c
> index c426497..b980b3f 100644
> --- a/net/netfilter/xt_recent.c
> +++ b/net/netfilter/xt_recent.c
> @@ -50,7 +50,6 @@ static unsigned int ip_list_uid = 0;
> static unsigned int ip_list_gid = 0;
> module_param(ip_list_tot, uint, 0400);
> module_param(ip_pkt_list_tot, uint, 0400);
> -module_param(ip_list_hash_size, uint, 0400);
> module_param(ip_list_perms, uint, 0400);
> module_param(ip_list_uid, uint, S_IRUGO | S_IWUSR);
> module_param(ip_list_gid, uint, S_IRUGO | S_IWUSR);
> --
> 1.7.7
>
next prev parent reply other threads:[~2012-07-12 15:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 23:52 xt_recent cleanups, xt_SYSRQ Jan Engelhardt
2012-07-10 23:52 ` [PATCH 1/4] netfilter: xt_recent: remove ip_list_hash_size parameter Jan Engelhardt
2012-07-12 15:42 ` Pablo Neira Ayuso [this message]
2012-07-10 23:52 ` [PATCH 2/4] netfilter: cleanup use of the term "IPs" Jan Engelhardt
2012-07-12 15:43 ` Pablo Neira Ayuso
2012-07-10 23:52 ` [PATCH 3/4] netfilter: use permission mnemonics in module_param Jan Engelhardt
2012-07-10 23:52 ` [PATCH 4/4] netfilter: xtables: inclusion of xt_SYSRQ Jan Engelhardt
2012-07-12 15:49 ` Pablo Neira Ayuso
2012-07-12 16:25 ` Jan Engelhardt
2012-07-12 20:26 ` Florian Westphal
2012-07-12 20:29 ` Jan Engelhardt
2012-07-12 20:35 ` Florian Westphal
2012-07-12 21:25 ` Jan Engelhardt
2012-07-13 9:16 ` Pablo Neira Ayuso
2012-07-14 1:43 ` Maciej Żenczykowski
2012-07-14 13:11 ` Pablo Neira Ayuso
2012-07-14 14:49 ` Aft nix
2012-07-14 15:24 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712154210.GC18793@1984 \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).