Re: [PATCH 5/5] nfacct: add timestamp option

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Aug 03, 2012 at 11:43:58AM +0200, Eric Leblond wrote:
> Hello,
> 
> Le vendredi 03 août 2012 à 11:35 +0200, Pablo Neira Ayuso a écrit :
> > On Wed, Aug 01, 2012 at 11:27:16PM +0200, Eric Leblond wrote:
> > > This patch adds a timestamp option to the nfacct plugin.
> > > If activated, nfacct output a timestamp which is computed just
> > > after sending the nfacct request.
> > 
> > I think it makes sense to make it unconditionally.
> > 
> > The dump of the counters without the time doesn't make too much sense
> > to me?
> > 
> > Let me know.
> 
> I think it was not originally added because some output format did not
> need it.

I guess you refer to GPRINT.

> Maybe we can make output of a timestamp by default and let
> people who want to spare the cycles of gettimeofday() set it to 0.

Hm, that means that we'll have two gettimeofday in case that GPRINT is
used (specifically if people configure this wrong, ie. setting on
timestamp both in GPRINT and NFACCT, that's likely to happen IMO).

I'm still undecided, but it seems to me we provide more fine-grain
control if timestamp is calculated in the output for the nfacct case.

I think we have to agree where to calculate the timestamp (input or
output plugins?) for consistency, or at least agreed on some policy
for this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html