From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: yefremov.denis@gmail.com, pablo@netfilter.org, kaber@trash.net,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
ldv-project@ispras.ru
Subject: Re: [PATCH] bridge: fix rcu dereference outside of rcu_read_lock
Date: Wed, 15 Aug 2012 15:10:25 -0700 (PDT) [thread overview]
Message-ID: <20120815.151025.1185439989487730645.davem@davemloft.net> (raw)
In-Reply-To: <20120814081933.30f3e868@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 14 Aug 2012 08:19:33 -0700
> Alternative solution for problem found by Linux Driver Verification
> project (linuxtesting.org).
>
> As it noted in the comment before the br_handle_frame_finish
> function, this function should be called under rcu_read_lock.
>
> The problem callgraph:
> br_dev_xmit -> br_nf_pre_routing_finish_bridge_slow ->
> -> br_handle_frame_finish -> br_port_get_rcu -> rcu_dereference
>
> And in this case there is no read-lock section.
>
> Reported-by: Denis Efremov <yefremov.denis@gmail.com>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Stephen.
Please CC: this to netdev next time. It's in a grey area whether I or
the netfilter folks should apply this one, and here I'm deciding to
take care of it.
prev parent reply other threads:[~2012-08-15 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 22:47 [PATCH] bridge: rcu_deref outside read-lock section Denis Efremov
2012-08-13 23:36 ` [PATCH] [NETFILTER] " Stephen Hemminger
2012-08-14 7:32 ` Denis
2012-08-14 8:08 ` [PATCH v2] " Denis Efremov
2012-08-14 15:19 ` [PATCH] bridge: fix rcu dereference outside of rcu_read_lock Stephen Hemminger
2012-08-15 22:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815.151025.1185439989487730645.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=ldv-project@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=shemminger@vyatta.com \
--cc=yefremov.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).