From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libxt_tcp: print space before, not after "flags:"
Date: Tue, 21 Aug 2012 12:37:10 +0200 [thread overview]
Message-ID: <20120821103710.GA31073@1984> (raw)
In-Reply-To: <m2k3wt4iaz.fsf@igel.home>
On Mon, Aug 20, 2012 at 06:52:36PM +0200, Andreas Schwab wrote:
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
> extensions/libxt_tcp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/extensions/libxt_tcp.c b/extensions/libxt_tcp.c
> index e849fa2..bbdec45 100644
> --- a/extensions/libxt_tcp.c
> +++ b/extensions/libxt_tcp.c
> @@ -278,11 +278,10 @@ static void
> print_flags(uint8_t mask, uint8_t cmp, int invert, int numeric)
> {
> if (mask || invert) {
> - printf("flags:%s", invert ? "!" : "");
> + printf(" flags:%s", invert ? "!" : "");
> if (numeric)
> - printf(" 0x%02X/0x%02X", mask, cmp);
> + printf("0x%02X/0x%02X", mask, cmp);
> else {
> - printf(" ");
> print_tcpf(mask);
> printf("/");
> print_tcpf(cmp);
Right, iptables -L -n is broken indeed:
tcp dpt:10flags: 0x17/0x02
Applied, thanks.
prev parent reply other threads:[~2012-08-21 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 16:52 [PATCH] libxt_tcp: print space before, not after "flags:" Andreas Schwab
2012-08-21 10:37 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821103710.GA31073@1984 \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).