* [PATCH] ipvs: Fix GSO support for IPVS DR IPv6 mode
@ 2012-08-22 11:11 Jesper Dangaard Brouer
0 siblings, 0 replies; only message in thread
From: Jesper Dangaard Brouer @ 2012-08-22 11:11 UTC (permalink / raw)
To: Simon Horman, Hans Schillstrom, lvs-devel, Jesper Dangaard Brouer
Cc: netdev, Julian Anastasov, Wensong Zhang, netfilter-devel
The MTU check in ip_vs_dr_xmit_v6() were missing a
check for skb_is_gso().
This e.g. caused issues for KVM IPVS setups, where different
Segmentation Offloading techniques are utilized, between guests,
via the virtio driver. This resulted in very bad performance,
due to the ICMPv6 "too big" messages didn't affect the sender.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
To Simon,
This should perhaps go to stable?
The patch is based on ipvs-next, but will apply on ipvs with an offset.
Jesper
net/netfilter/ipvs/ip_vs_xmit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
index 543a554..80c3006 100644
--- a/net/netfilter/ipvs/ip_vs_xmit.c
+++ b/net/netfilter/ipvs/ip_vs_xmit.c
@@ -1113,7 +1113,7 @@ ip_vs_dr_xmit_v6(struct sk_buff *skb, struct ip_vs_conn *cp,
/* MTU checking */
mtu = dst_mtu(&rt->dst);
- if (skb->len > mtu) {
+ if (skb->len > mtu && !skb_is_gso(skb))) {
if (!skb->dev) {
struct net *net = dev_net(skb_dst(skb)->dev);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-22 11:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 11:11 [PATCH] ipvs: Fix GSO support for IPVS DR IPv6 mode Jesper Dangaard Brouer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).