From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix out-of-bounds access in nat addr selection
Date: Mon, 10 Sep 2012 11:14:57 +0200 [thread overview]
Message-ID: <20120910091457.GA5484@1984> (raw)
In-Reply-To: <1346875828-14054-1-git-send-email-fw@strlen.de>
On Wed, Sep 05, 2012 at 10:10:28PM +0200, Florian Westphal wrote:
> include/linux/jhash.h:138:16: warning: array subscript is above array bounds
> [jhash2() expects the number of u32 in the key]
Applied to -next, thanks Florian.
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Only affects -next.
> note that I also get same warning for hash_by_src(); but
> hash = jhash2((u32 *)&tuple->src, sizeof(tuple->src) / sizeof(u32),
> tuple->dst.protonum ^ zone ^ nf_conntrack_hash_rnd);
> looks correct to me.
It also seems correct to me, that tuple->src is 5*4 bytes long.
I'm not hitting any warning with gcc-4.7 though.
prev parent reply other threads:[~2012-09-10 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 20:10 [PATCH] netfilter: fix out-of-bounds access in nat addr selection Florian Westphal
2012-09-10 9:14 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910091457.GA5484@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).