* [PATCH] netfilter: nfnetlink_queue: remove pointless conditional before kfree_skb()
@ 2012-08-28 13:14 Wei Yongjun
2012-09-10 9:15 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-08-28 13:14 UTC (permalink / raw)
To: pablo, kaber; +Cc: yongjun_wei, netfilter-devel, netfilter, coreteam
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Remove pointless conditional before kfree_skb().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
net/netfilter/nfnetlink_queue_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
index c0496a5..5c2d78d 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -406,8 +406,7 @@ nfqnl_build_packet_message(struct nfqnl_instance *queue,
return skb;
nla_put_failure:
- if (skb)
- kfree_skb(skb);
+ kfree_skb(skb);
net_err_ratelimited("nf_queue: error creating packet message\n");
return NULL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: nfnetlink_queue: remove pointless conditional before kfree_skb()
2012-08-28 13:14 [PATCH] netfilter: nfnetlink_queue: remove pointless conditional before kfree_skb() Wei Yongjun
@ 2012-09-10 9:15 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2012-09-10 9:15 UTC (permalink / raw)
To: Wei Yongjun; +Cc: kaber, yongjun_wei, netfilter-devel, netfilter, coreteam
On Tue, Aug 28, 2012 at 09:14:15PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove pointless conditional before kfree_skb().
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-10 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 13:14 [PATCH] netfilter: nfnetlink_queue: remove pointless conditional before kfree_skb() Wei Yongjun
2012-09-10 9:15 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).