From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: davem@davemloft.net, kaber@trash.net, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: netfilter: combine ipt_REDIRECT and ip6t_REDIRECT
Date: Fri, 21 Sep 2012 12:11:32 +0200 [thread overview]
Message-ID: <20120921101132.GB24612@1984> (raw)
In-Reply-To: <1347586832-6190-3-git-send-email-jengelh@inai.de>
On Fri, Sep 14, 2012 at 03:40:32AM +0200, Jan Engelhardt wrote:
> (Same rationale as previous commit.)
Please, even if the changelog is very similar, I prefer if you
duplicate. This is good later on in case you want to check the
history, in that case we may not see the previous commit.
And more thing regarding this patch:
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> net/ipv4/netfilter/Kconfig | 12 +--
> net/ipv4/netfilter/Makefile | 1 -
> net/ipv6/netfilter/Kconfig | 11 ---
> net/ipv6/netfilter/Makefile | 1 -
> net/ipv6/netfilter/ip6t_REDIRECT.c | 98 -------------------
> net/netfilter/Kconfig | 11 +++
> net/netfilter/Makefile | 1 +
> net/netfilter/xt_REDIRECT.c | 190 ++++++++++++++++++++++++++++++++++++
It seems you forgot to delete ipt_REDIRECT.c, I've done it myself.
So this patch applied as well.
prev parent reply other threads:[~2012-09-21 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 1:40 Combine two modules Jan Engelhardt
2012-09-14 1:40 ` [PATCH 1/2] net: netfilter: combine ipt_NETMAP and ip6t_NETMAP Jan Engelhardt
2012-09-14 11:38 ` Patrick McHardy
2012-09-21 10:09 ` Pablo Neira Ayuso
2012-09-14 1:40 ` [PATCH 2/2] net: netfilter: combine ipt_REDIRECT and ip6t_REDIRECT Jan Engelhardt
2012-09-14 11:53 ` Patrick McHardy
2012-09-21 10:11 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921101132.GB24612@1984 \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=jengelh@inai.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).