From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net, jrobinson@infoblox.com
Subject: Re: [PATCH] netfilter: have r->cost != 0 case work
Date: Wed, 26 Sep 2012 01:27:39 +0200 [thread overview]
Message-ID: <20120925232739.GB12349@1984> (raw)
In-Reply-To: <alpine.LNX.2.01.1209251648570.12652@nerf07.vanv.qr>
On Tue, Sep 25, 2012 at 04:52:32PM +0200, Jan Engelhardt wrote:
> On Tuesday 2012-09-25 16:39, Pablo Neira Ayuso wrote:
> >On Sat, Sep 22, 2012 at 10:26:52AM +0200, Jan Engelhardt wrote:
> >> Commit v2.6.19-rc1~1272^2~41 tells us that r->cost != 0 can happen when
> >> a running state is saved to userspace and then reinstated from there.
> >>
> >> Make sure that priv is initialized with some values when that happens.
> >
> >Just to clarify: With this patch, we go back to the situation in which
> >the state is reset on unrelated rule updates, right?
>
> Before this patch, when userspace updated a rule, random things
> would happen on matching due to use of uninitialized memory.
I know that ;-)
> Now, the values are initialized, and implies that the credit is reset on
> table update.
This is what I wanted to confirm. Thanks Jan.
I'll pass this to David. Let's see if we can get this into 3.6-rc.
next prev parent reply other threads:[~2012-09-25 23:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <505CE985.7000907@infoblox.com>
2012-09-22 3:09 ` Bug in limit_mt_check() Jan Engelhardt
2012-09-22 8:03 ` Jan Engelhardt
2012-09-22 8:13 ` Jan Engelhardt
2012-09-22 8:26 ` [PATCH] netfilter: have r->cost != 0 case work Jan Engelhardt
2012-09-23 12:43 ` Patrick McHardy
2012-09-24 13:02 ` Jan Engelhardt
2012-09-24 13:12 ` Patrick McHardy
2012-09-24 20:34 ` Jim Robinson
2012-09-24 21:30 ` Jan Engelhardt
2012-09-25 14:39 ` Pablo Neira Ayuso
2012-09-25 14:52 ` Jan Engelhardt
2012-09-25 23:27 ` Pablo Neira Ayuso [this message]
2012-09-26 13:28 ` Jan Engelhardt
2012-09-26 14:47 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925232739.GB12349@1984 \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=jrobinson@infoblox.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).