* static build breakage - 1.4.16.2. @ 2012-10-08 21:04 Maciej Żenczykowski 2012-10-08 21:09 ` Maciej Żenczykowski 2012-10-08 22:04 ` Jan Engelhardt 0 siblings, 2 replies; 6+ messages in thread From: Maciej Żenczykowski @ 2012-10-08 21:04 UTC (permalink / raw) To: Netfilter Development Mailinglist Not entirely clear what's breaking, but: ./configure --enable-static --disable-shared --enable-ipv4 --enable-ipv6 make[3]: *** No rule to make target `libxt_NOTRACK.o', needed by `libext.a'. Stop. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: static build breakage - 1.4.16.2. 2012-10-08 21:04 static build breakage - 1.4.16.2 Maciej Żenczykowski @ 2012-10-08 21:09 ` Maciej Żenczykowski 2012-10-08 22:04 ` Jan Engelhardt 1 sibling, 0 replies; 6+ messages in thread From: Maciej Żenczykowski @ 2012-10-08 21:09 UTC (permalink / raw) To: Netfilter Development Mailinglist extensions/GNUmakefile.in:118:libext.a: initext.o ${libext_objs} extensions/GNUmakefile.in:61:@ENABLE_STATIC_TRUE@ libext_objs := ${pfx_objs} extensions/GNUmakefile.in:48:pfx_objs := $(patsubst %,libxt_%.o,${pfx_build_mod}) extensions/GNUmakefile.in:41:pfx_build_mod := $(patsubst ${srcdir}/libxt_%.c,%,$(sort $(wildcard ${srcdir}/libxt_*.c))) extensions/GNUmakefile.in:42:pfx_build_mod += NOTRACK state extensions/GNUmakefile.in:45:pfx_build_mod := $(filter-out @blacklist_modules@,${pfx_build_mod}) so I guess that explains why it fails, but no idea what the right fix is. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: static build breakage - 1.4.16.2. 2012-10-08 21:04 static build breakage - 1.4.16.2 Maciej Żenczykowski 2012-10-08 21:09 ` Maciej Żenczykowski @ 2012-10-08 22:04 ` Jan Engelhardt 2012-10-09 0:16 ` Maciej Żenczykowski 1 sibling, 1 reply; 6+ messages in thread From: Jan Engelhardt @ 2012-10-08 22:04 UTC (permalink / raw) To: Maciej Żenczykowski; +Cc: Netfilter Development Mailinglist On Monday 2012-10-08 23:04, Maciej Żenczykowski wrote: > >Not entirely clear what's breaking, but: > >./configure --enable-static --disable-shared --enable-ipv4 --enable-ipv6 > >make[3]: *** No rule to make target `libxt_NOTRACK.o', needed by >`libext.a'. Stop. > (N.B. You can have both --enable-static and --enable-shared) This patch seems to do it for me. Ok for you? origin git://git.inai.de/iptables master parent c1a150c98fc94858a440550f0cb347a6060ebb30 (v1.4.16.2) commit 13527271f1db3c0576ab47b84e85d979f56281a6 Author: Jan Engelhardt <jengelh@inai.de> Date: Mon Oct 8 23:56:12 2012 +0200 build: remove symlink-only extensions from static object list $ ./configure --enable-static --disable-shared --enable-ipv4 --enable-ipv6 && make [...] make[3]: *** No rule to make target "libxt_NOTRACK.o", needed by "libext.a". Stop. Signed-off-by: Jan Engelhardt <jengelh@inai.de> --- extensions/GNUmakefile.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/extensions/GNUmakefile.in b/extensions/GNUmakefile.in index 8b38df9..1cef239 100644 --- a/extensions/GNUmakefile.in +++ b/extensions/GNUmakefile.in @@ -39,7 +39,7 @@ endif # Wildcard module list # pfx_build_mod := $(patsubst ${srcdir}/libxt_%.c,%,$(sort $(wildcard ${srcdir}/libxt_*.c))) -pfx_build_mod += NOTRACK state +pfx_symlinks := NOTRACK state @ENABLE_IPV4_TRUE@ pf4_build_mod := $(patsubst ${srcdir}/libipt_%.c,%,$(sort $(wildcard ${srcdir}/libipt_*.c))) @ENABLE_IPV6_TRUE@ pf6_build_mod := $(patsubst ${srcdir}/libip6t_%.c,%,$(sort $(wildcard ${srcdir}/libip6t_*.c))) pfx_build_mod := $(filter-out @blacklist_modules@,${pfx_build_mod}) @@ -48,7 +48,7 @@ pf6_build_mod := $(filter-out @blacklist_modules@,${pf6_build_mod}) pfx_objs := $(patsubst %,libxt_%.o,${pfx_build_mod}) pf4_objs := $(patsubst %,libipt_%.o,${pf4_build_mod}) pf6_objs := $(patsubst %,libip6t_%.o,${pf6_build_mod}) -pfx_solibs := $(patsubst %,libxt_%.so,${pfx_build_mod}) +pfx_solibs := $(patsubst %,libxt_%.so,${pfx_build_mod} ${pfx_symlinks}) pf4_solibs := $(patsubst %,libipt_%.so,${pf4_build_mod}) pf6_solibs := $(patsubst %,libip6t_%.so,${pf6_build_mod}) @@ -220,7 +220,7 @@ man_run = \ done >$@; matches.man: .initext.dd .initext4.dd .initext6.dd $(wildcard ${srcdir}/lib*.man) - $(call man_run,$(call ex_matches,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod})) + $(call man_run,$(call ex_matches,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod} ${pfx_symlinks})) targets.man: .initext.dd .initext4.dd .initext6.dd $(wildcard ${srcdir}/lib*.man) - $(call man_run,$(call ex_targets,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod})) + $(call man_run,$(call ex_targets,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod} ${pfx_symlinks})) -- # Created with git-export-patch -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: static build breakage - 1.4.16.2. 2012-10-08 22:04 ` Jan Engelhardt @ 2012-10-09 0:16 ` Maciej Żenczykowski 2012-10-09 0:49 ` Jan Engelhardt 2012-10-09 10:04 ` Pablo Neira Ayuso 0 siblings, 2 replies; 6+ messages in thread From: Maciej Żenczykowski @ 2012-10-09 0:16 UTC (permalink / raw) To: Jan Engelhardt; +Cc: Netfilter Development Mailinglist > (N.B. You can have both --enable-static and --enable-shared) Yeah, but I just want a small binary and don't need shared support (indeed it's even undesirable). > This patch seems to do it for me. Ok for you? Looks like it. Care to push and release as .3? Although perhaps calling it pfx_aliases or pfx_build_alias would be better (there doesn't seem to be any actual symlinks are there?) This also skips the blacklist_modules logic, which I guess in this case doesn't matter. > @@ -39,7 +39,7 @@ endif > # Wildcard module list > # > pfx_build_mod := $(patsubst ${srcdir}/libxt_%.c,%,$(sort $(wildcard ${srcdir}/libxt_*.c))) > -pfx_build_mod += NOTRACK state > +pfx_symlinks := NOTRACK state > @ENABLE_IPV4_TRUE@ pf4_build_mod := $(patsubst ${srcdir}/libipt_%.c,%,$(sort $(wildcard ${srcdir}/libipt_*.c))) > @ENABLE_IPV6_TRUE@ pf6_build_mod := $(patsubst ${srcdir}/libip6t_%.c,%,$(sort $(wildcard ${srcdir}/libip6t_*.c))) > pfx_build_mod := $(filter-out @blacklist_modules@,${pfx_build_mod}) > @@ -48,7 +48,7 @@ pf6_build_mod := $(filter-out @blacklist_modules@,${pf6_build_mod}) > pfx_objs := $(patsubst %,libxt_%.o,${pfx_build_mod}) > pf4_objs := $(patsubst %,libipt_%.o,${pf4_build_mod}) > pf6_objs := $(patsubst %,libip6t_%.o,${pf6_build_mod}) > -pfx_solibs := $(patsubst %,libxt_%.so,${pfx_build_mod}) > +pfx_solibs := $(patsubst %,libxt_%.so,${pfx_build_mod} ${pfx_symlinks}) > pf4_solibs := $(patsubst %,libipt_%.so,${pf4_build_mod}) > pf6_solibs := $(patsubst %,libip6t_%.so,${pf6_build_mod}) > > @@ -220,7 +220,7 @@ man_run = \ > done >$@; > > matches.man: .initext.dd .initext4.dd .initext6.dd $(wildcard ${srcdir}/lib*.man) > - $(call man_run,$(call ex_matches,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod})) > + $(call man_run,$(call ex_matches,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod} ${pfx_symlinks})) > > targets.man: .initext.dd .initext4.dd .initext6.dd $(wildcard ${srcdir}/lib*.man) > - $(call man_run,$(call ex_targets,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod})) > + $(call man_run,$(call ex_targets,${pfx_build_mod} ${pf4_build_mod} ${pf6_build_mod} ${pfx_symlinks})) > -- > # Created with git-export-patch ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: static build breakage - 1.4.16.2. 2012-10-09 0:16 ` Maciej Żenczykowski @ 2012-10-09 0:49 ` Jan Engelhardt 2012-10-09 10:04 ` Pablo Neira Ayuso 1 sibling, 0 replies; 6+ messages in thread From: Jan Engelhardt @ 2012-10-09 0:49 UTC (permalink / raw) To: Maciej Żenczykowski; +Cc: Netfilter Development Mailinglist On Tuesday 2012-10-09 02:16, Maciej Żenczykowski wrote: >> (N.B. You can have both --enable-static and --enable-shared) > >Yeah, but I just want a small binary and don't need shared support >(indeed it's even undesirable). > >> This patch seems to do it for me. Ok for you? > >Looks like it. >Care to push and release as .3? > >Although perhaps calling it pfx_aliases or pfx_build_alias would be >better (there doesn't seem to be any actual symlinks are there?) You should build with --disable-static sometimes. :) >This also skips the blacklist_modules logic, which I guess in this >case doesn't matter. Indeed not. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: static build breakage - 1.4.16.2. 2012-10-09 0:16 ` Maciej Żenczykowski 2012-10-09 0:49 ` Jan Engelhardt @ 2012-10-09 10:04 ` Pablo Neira Ayuso 1 sibling, 0 replies; 6+ messages in thread From: Pablo Neira Ayuso @ 2012-10-09 10:04 UTC (permalink / raw) To: Maciej Żenczykowski Cc: Jan Engelhardt, Netfilter Development Mailinglist On Mon, Oct 08, 2012 at 05:16:14PM -0700, Maciej Żenczykowski wrote: > > (N.B. You can have both --enable-static and --enable-shared) > > Yeah, but I just want a small binary and don't need shared support > (indeed it's even undesirable). > > > This patch seems to do it for me. Ok for you? > > Looks like it. Applied, thanks a lot. > Care to push and release as .3? Will do in a couple of days. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-09 10:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-10-08 21:04 static build breakage - 1.4.16.2 Maciej Żenczykowski 2012-10-08 21:09 ` Maciej Żenczykowski 2012-10-08 22:04 ` Jan Engelhardt 2012-10-09 0:16 ` Maciej Żenczykowski 2012-10-09 0:49 ` Jan Engelhardt 2012-10-09 10:04 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).