From: Greg KH <gregkh@linuxfoundation.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: stable@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: ipset: timeout fixing bug broke SET target special timeout value
Date: Tue, 16 Oct 2012 09:32:00 -0700 [thread overview]
Message-ID: <20121016163200.GB4777@kroah.com> (raw)
In-Reply-To: <20121016093653.GA18252@1984>
On Tue, Oct 16, 2012 at 11:36:53AM +0200, Pablo Neira Ayuso wrote:
> On Mon, Oct 15, 2012 at 04:40:22PM -0700, Greg KH wrote:
> > On Mon, Oct 15, 2012 at 04:27:50PM -0700, Greg KH wrote:
> > > On Mon, Oct 15, 2012 at 04:22:25PM -0700, Greg KH wrote:
> > > > On Thu, Oct 11, 2012 at 12:17:38PM +0200, pablo@netfilter.org wrote:
> > > > > From: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
> > > > >
> > > > > The patch "127f559 netfilter: ipset: fix timeout value overflow bug"
> > > > > broke the SET target when no timeout was specified.
> > > > >
> > > > > Reported-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
> > > > > Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
> > > > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > > > > ---
> > > > >
> > > > > This patch requires:
> > > > >
> > > > > commit 127f559127f5175e4bec3dab725a34845d956591
> > > > > Author: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
> > > > > Date: Mon May 7 02:35:44 2012 +0000
> > > > >
> > > > > netfilter: ipset: fix timeout value overflow bug
> > > > >
> > > > > Large timeout parameters could result wrong timeout values due to
> > > > > an overflow at msec to jiffies conversion (reported by Andreas Herz)
> > > >
> > > > This patch doesn't apply to the 3.0.y series, care to provide a
> > > > backport, and a backported version of the original patch above that
> > > > needs it?
> > >
> > > Oh wait, should I apply the 3.0.y specific patches first? I'll go do
> > > that and see if these two then apply here...
> >
> > Nope, doesn't apply. Care to backport both of these patches for 3.0.y
> > and send them to us?
>
> I can send you the backport for 3.2 but not for 3.0.
>
> That fix is for one feature that was added in 3.1, so no way to make it
> for 3.0 :-)
Ah, ok, no worries then.
greg k-h
next prev parent reply other threads:[~2012-10-16 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 10:17 [PATCH] Netfilter/IPVS updates for stable 3.4 onwards pablo
2012-10-11 10:17 ` [PATCH 1/3] ipvs: fix oops in ip_vs_dst_event on rmmod pablo
2012-10-11 10:17 ` [PATCH 2/3] netfilter: nf_conntrack: fix racy timer handling with reliable events pablo
2012-10-11 10:17 ` [PATCH 3/3] netfilter: ipset: timeout fixing bug broke SET target special timeout value pablo
2012-10-15 23:22 ` Greg KH
2012-10-15 23:27 ` Greg KH
2012-10-15 23:40 ` Greg KH
2012-10-16 9:36 ` Pablo Neira Ayuso
2012-10-16 16:32 ` Greg KH [this message]
2012-10-17 2:09 ` Ben Hutchings
2012-10-11 22:20 ` [PATCH] Netfilter/IPVS updates for stable 3.4 onwards David Miller
2012-10-15 23:22 ` Greg KH
2012-10-15 23:18 ` Greg KH
2012-10-16 9:04 ` Pablo Neira Ayuso
2012-10-16 14:38 ` Pablo Neira Ayuso
2012-10-16 16:31 ` Greg KH
2012-10-16 21:04 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2012-10-11 10:07 pablo
2012-10-11 10:07 ` [PATCH 3/3] netfilter: ipset: timeout fixing bug broke SET target special timeout value pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016163200.GB4777@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).