netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Torsten Luettgert <ml-netfilter@enda.eu>
To: netfilter-devel@vger.kernel.org
Subject: TEE broken in 3.6
Date: Tue, 16 Oct 2012 21:13:19 +0200	[thread overview]
Message-ID: <20121016211319.3f07a7e3@goldlack.enda.eu> (raw)

Hi,

today, I found that the TEE target doesn't work any longer in 3.6 and
following kernels. The problem is that it tries to ARP-lookup the
original destination address of the forwarded packet, not the address
of the gateway.

I git bisected and found that this commit broke it:

commit f8126f1d5136be1ca1a3536d43ad7a710b5620f8
Author: David S. Miller <davem@davemloft.net>
Date:   Fri Jul 13 05:03:45 2012 -0700

    ipv4: Adjust semantics of rt->rt_gateway.
    
    In order to allow prefixed routes, we have to adjust how rt_gateway
    is set and interpreted.
    
    The new interpretation is:
    
    1) rt_gateway == 0, destination is on-link, nexthop is iph->daddr
    
    2) rt_gateway != 0, destination requires a nexthop gateway
    
    Abstract the fetching of the proper nexthop value using a new
    inline helper, rt_nexthop(), as suggested by Joe Perches.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Tested-by: Vijay Subramanian <subramanian.vijay@gmail.com>

which seems plausible. I'm not versed enough in netfilter/routing code
to fix it myself. Could any of you wizards help?

Thanks,
Torsten

             reply	other threads:[~2012-10-16 19:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 19:13 Torsten Luettgert [this message]
2012-10-16 20:00 ` TEE broken in 3.6 Eric Dumazet
2012-10-17  7:45   ` Torsten Luettgert
2012-10-17  7:48     ` Eric Dumazet
2012-10-17  8:15       ` Pablo Neira Ayuso
2012-10-17  8:33         ` [PATCH] netfilter: xt_TEE: dont use destination address found in header Eric Dumazet
2012-10-17  8:23       ` TEE broken in 3.6 Pablo Neira Ayuso
2012-10-17  8:34         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121016211319.3f07a7e3@goldlack.enda.eu \
    --to=ml-netfilter@enda.eu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).