From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ulrich Weber <ulrich.weber@sophos.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nf_nat: dont check for port change on ICMP tuples
Date: Sun, 28 Oct 2012 23:49:56 +0100 [thread overview]
Message-ID: <20121028224956.GA828@1984> (raw)
In-Reply-To: <20121025153445.GA22403@uweber-WS>
On Thu, Oct 25, 2012 at 05:34:45PM +0200, Ulrich Weber wrote:
> ICMP tuples have id in src and type/code in dst.
> So comparing src.u.all with dst.u.all will always fail here
> and ip_xfrm_me_harder() is called for every ICMP packet,
> even if there was no NAT...
Tracking the history, this seems to be there since really long time
ago. I'll pass a backport of this to -stable.
Applied, thanks Ulrich.
next prev parent reply other threads:[~2012-10-28 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 15:34 [PATCH] nf_nat: dont check for port change on ICMP tuples Ulrich Weber
2012-10-28 22:49 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-31 12:13 Ulrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121028224956.GA828@1984 \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ulrich.weber@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).