netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_tables: replace built-in tables by chain types
Date: Mon, 5 Nov 2012 15:32:16 +0100	[thread overview]
Message-ID: <20121105143216.GA7280@1984> (raw)
In-Reply-To: <5097B7AC.3010206@linux.intel.com>

On Mon, Nov 05, 2012 at 02:57:16PM +0200, Tomasz Bursztyka wrote:
> Hi Pablo,
> 
> Don't know why, but git cannot apply properly the patch at once.
> Though, nothing seems to prevent such thing.
> Anyway:
> 
> >@@ -1807,6 +1793,10 @@ static int __init nf_tables_module_init(void)
> >  	if (err<  0)
> >  		goto err2;
> >
> >+	nft_register_chain_type(&filter_ipv4);
> >+	nft_register_chain_type(&filter_ipv6);
> >+	nft_register_chain_type(&filter_bridge);
> >+
> >  	pr_info("nf_tables: (c) 2007-2009 Patrick McHardy<kaber@trash.net>\n");
> >  	return 0;
> >
> >@@ -1818,6 +1808,9 @@ err1:
> >
> >  static void __exit nf_tables_module_exit(void)
> >  {
> >+	nft_unregister_chain_type(&filter_ipv4);
> >+	nft_unregister_chain_type(&filter_ipv6);
> >+	nft_unregister_chain_type(&filter_bridge);
> >  	nfnetlink_subsys_unregister(&nf_tables_subsys);
> >  	nf_tables_core_module_exit();
> >  }
> >-- 
> 
> filter_bridge declaration is missing.

It's a leftover, remove it. It's already fixed here. Sorry for the
inconvenience.

  reply	other threads:[~2012-11-05 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04 18:33 [PATCH] netfilter: nf_tables: replace built-in tables by chain types pablo
2012-11-05 12:57 ` Tomasz Bursztyka
2012-11-05 14:32   ` Pablo Neira Ayuso [this message]
2012-11-05 14:35     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121105143216.GA7280@1984 \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=tomasz.bursztyka@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).