From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: ipv6: add getsockopt to retrieve origdst
Date: Tue, 13 Nov 2012 10:39:50 +0100 [thread overview]
Message-ID: <20121113093950.GA24755@1984> (raw)
In-Reply-To: <20121113085930.GE20678@breakpoint.cc>
On Tue, Nov 13, 2012 at 09:59:30AM +0100, Florian Westphal wrote:
> YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> wrote:
> > pablo@netfilter.org wrote:
> > > From: Florian Westphal <fw@strlen.de>
> > > + sin6.sin6_scope_id = sk->sk_bound_dev_if;
> > > +
> > > + nf_ct_put(ct);
> > > + return copy_to_user(user, &sin6, sizeof(sin6)) ? -EFAULT : 0;
> > > +}
> > > +
> >
> > I think we should set sin6_scope_id to sk->sk_bound_dev_if only if the
> > destination is link-local address.
>
> Right, I see that getpeer/sockname has this test.
>
> Dave, please either apply the patch as is (I'd submit a fixup)
> or discard i, I'll then send a V2 with added
> ipv6_addr_type(&sin->sin6_addr) & IPV6_ADDR_LINKLOCAL
> test to Pablo.
Please, send me a follow-up patch, I'll apply and request a new pull
request.
Thanks.
next prev parent reply other threads:[~2012-11-13 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 0:06 [PATCH 0/3] netfilter updates for net-next pablo
2012-11-13 0:06 ` [PATCH 1/3] ipvs: remove silly double assignment pablo
2012-11-13 0:06 ` [PATCH 2/3] netfilter: nf_nat: use PTR_RET pablo
2012-11-13 0:06 ` [PATCH 3/3] netfilter: ipv6: add getsockopt to retrieve origdst pablo
2012-11-13 3:29 ` YOSHIFUJI Hideaki
2012-11-13 8:59 ` Florian Westphal
2012-11-13 9:39 ` Pablo Neira Ayuso [this message]
2012-11-13 12:40 ` [PATCH 0/3] netfilter updates for net-next Pablo Neira Ayuso
2012-11-13 19:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113093950.GA24755@1984 \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).