From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 2/3] api: add connlabel api and attribute
Date: Thu, 15 Nov 2012 22:07:11 +0100 [thread overview]
Message-ID: <20121115210711.GJ20678@breakpoint.cc> (raw)
In-Reply-To: <1352994611-3707-3-git-send-email-fw@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> --- a/src/conntrack/api.c
> +++ b/src/conntrack/api.c
> @@ -95,6 +95,8 @@ void nfct_destroy(struct nf_conntrack *ct)
> free(ct->secctx);
> if (ct->helper_info)
> free(ct->helper_info);
> + if (ct->connlabels)
> + nfct_bitmask_destroy(ct->connlabels);
> free(ct);
> ct = NULL; /* bugtrap */
> }
Will cause double-free for nfct_cloned objects.
I'll fix nfct_clone and will add the missing nfct_copy*
handling in the next iteration, some time next week.
next prev parent reply other threads:[~2012-11-15 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 15:50 [PATCH 0/3] libnetfilter_conntrack: add connlabel support Florian Westphal
2012-11-15 15:50 ` [PATCH 1/3] api: add nfct_bitmask object Florian Westphal
2012-11-15 15:50 ` [PATCH 2/3] api: add connlabel api and attribute Florian Westphal
2012-11-15 21:07 ` Florian Westphal [this message]
2012-11-15 15:50 ` [PATCH 3/3] examples: add connlabel dump/set/clear demo programs Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115210711.GJ20678@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).