From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] examples: nf-queue: fix api usage
Date: Sun, 25 Nov 2012 23:34:13 +0100 [thread overview]
Message-ID: <20121125223413.GA25197@breakpoint.cc> (raw)
In-Reply-To: <20121125204725.GA5456@1984>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, Nov 25, 2012 at 04:54:32PM +0100, Florian Westphal wrote:
> > 1. struct nlattr *attr[NFQA_MAX+1] must be initialized.
> > Otherwise, attr[FOO] might be non-null after parsing
> > even if that attribute isn't present in the message.
> >
> > 2. mnl_attr_get_payload will never return NULL (if the
> > attribute is NULL, it returns MNL_ATTR_HDRLEN.)
>
> Fine with me, just a question:
> > + puts("sleep 10 seconds");
> > + sleep(10);
>
> Why this sleep 10 seconds? :-)
Uhhh... Nothing to see here, move along ;-)
Thanks for spotting, i applied the patch (without
this leftover debug crud...).
prev parent reply other threads:[~2012-11-25 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 15:54 [PATCH] examples: nf-queue: fix api usage Florian Westphal
2012-11-25 20:47 ` Pablo Neira Ayuso
2012-11-25 22:34 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121125223413.GA25197@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).