From: Florian Westphal <fw@strlen.de>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: nf_conntrack: improve nf_conn object traceability
Date: Mon, 3 Dec 2012 12:06:10 +0100 [thread overview]
Message-ID: <20121203110610.GA11627@breakpoint.cc> (raw)
In-Reply-To: <1354197082-8431-2-git-send-email-pablo@netfilter.org>
pablo@netfilter.org <pablo@netfilter.org> wrote:
Hi Pablo,
I have one question related to ct object destruction:
> @@ -247,6 +245,9 @@ void nf_ct_delete_from_lists(struct nf_conn *ct)
> * Otherwise we can get spurious warnings. */
> NF_CT_STAT_INC(net, delete_list);
> clean_from_lists(ct);
> + /* add this conntrack to the dying list */
> + hlist_nulls_add_head(&ct->tuplehash[IP_CT_DIR_ORIGINAL].hnnode,
> + &net->ct.dying);
> spin_unlock_bh(&nf_conntrack_lock);
i.o.w., conntrack objects that were in hash table are now always moved
to the dying list. Shouldn't nf_ct_release_dying_list() be adjusted,
too? It still seems to assume that the dying list only contains
alive conntack objects whose events have not been delivered yet.
next prev parent reply other threads:[~2012-12-03 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 13:51 [PATCH 0/2] improve conntrack object traceability pablo
2012-11-29 13:51 ` [PATCH 1/2] netfilter: nf_conntrack: improve nf_conn " pablo
2012-12-03 11:06 ` Florian Westphal [this message]
2012-12-03 12:50 ` Pablo Neira Ayuso
2012-12-03 13:28 ` Pablo Neira Ayuso
2012-12-03 14:17 ` Florian Westphal
2012-12-03 14:33 ` Pablo Neira Ayuso
2012-11-29 13:51 ` [PATCH 2/2] netfilter: ctnetlink: dump entries from the dying and unconfirmed lists pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203110610.GA11627@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).