From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH 1/2] netfilter: nf_conntrack: improve nf_conn object traceability Date: Mon, 3 Dec 2012 12:06:10 +0100 Message-ID: <20121203110610.GA11627@breakpoint.cc> References: <1354197082-8431-1-git-send-email-pablo@netfilter.org> <1354197082-8431-2-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: pablo@netfilter.org Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:40146 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754314Ab2LCLGL (ORCPT ); Mon, 3 Dec 2012 06:06:11 -0500 Content-Disposition: inline In-Reply-To: <1354197082-8431-2-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: pablo@netfilter.org wrote: Hi Pablo, I have one question related to ct object destruction: > @@ -247,6 +245,9 @@ void nf_ct_delete_from_lists(struct nf_conn *ct) > * Otherwise we can get spurious warnings. */ > NF_CT_STAT_INC(net, delete_list); > clean_from_lists(ct); > + /* add this conntrack to the dying list */ > + hlist_nulls_add_head(&ct->tuplehash[IP_CT_DIR_ORIGINAL].hnnode, > + &net->ct.dying); > spin_unlock_bh(&nf_conntrack_lock); i.o.w., conntrack objects that were in hash table are now always moved to the dying list. Shouldn't nf_ct_release_dying_list() be adjusted, too? It still seems to assume that the dying list only contains alive conntack objects whose events have not been delivered yet.