From: David Miller <davem@davemloft.net>
To: dries.dewinter@gmail.com
Cc: pablo@netfilter.org, kaber@trash.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] net: ICMPv6 packets transmitted on wrong interface if nfmark is mangled
Date: Wed, 05 Dec 2012 12:57:00 -0500 (EST) [thread overview]
Message-ID: <20121205.125700.2246243377198648534.davem@davemloft.net> (raw)
In-Reply-To: <CA+e04fgiMDoaCx0fpdK5F6YfJ_CSOZ13q1fn9xs7De4JO02c6g@mail.gmail.com>
From: Dries De Winter <dries.dewinter@gmail.com>
Date: Wed, 5 Dec 2012 14:41:59 +0100
> My "noreroute" patch will not fix this. Therefore it's indeed maybe
> better to add a simple check to ip6_route_me_harder(): not a check for
> ICMPv6, but a check for (ipv6_addr_type(&iph->daddr) &
> IPV6_ADDR_LINKLOCAL) instead. What do you think?
What if a packet is rewritten from a non-link-local destination address
into a link-local one? Or vice versa?
Your test will fail in those cases.
next prev parent reply other threads:[~2012-12-05 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <22884633.2468.1354092935228.JavaMail.driesdw@sahwcmp0020>
2012-11-28 9:09 ` [PATCH] net: ICMPv6 packets transmitted on wrong interface if nfmark is mangled Dries De Winter
2012-11-28 23:30 ` David Miller
2012-11-30 12:29 ` Dries De Winter
2012-11-30 17:22 ` David Miller
2012-12-03 12:46 ` Dries De Winter
2012-12-03 19:11 ` David Miller
2012-12-03 21:31 ` Dries De Winter
2012-12-03 22:06 ` David Miller
2012-12-05 13:41 ` Dries De Winter
2012-12-05 17:57 ` David Miller [this message]
2012-12-06 9:11 ` Dries De Winter
2012-12-03 23:38 ` Jan Engelhardt
2012-12-03 23:52 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205.125700.2246243377198648534.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dries.dewinter@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).