From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH rfc] netfilter: two xtables matches Date: Thu, 6 Dec 2012 06:22:46 +0100 Message-ID: <20121206052246.GA2905@1984> References: <1354735339-13402-1-git-send-email-willemb@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Willem de Bruijn , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , David Miller , kaber@trash.net To: Jan Engelhardt Return-path: Received: from mail.us.es ([193.147.175.20]:50584 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495Ab2LFFWz (ORCPT ); Thu, 6 Dec 2012 00:22:55 -0500 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Dec 05, 2012 at 09:00:36PM +0100, Jan Engelhardt wrote: > On Wednesday 2012-12-05 20:28, Willem de Bruijn wrote: > > >Somehow, the first part of this email went missing. Not critical, > >but for completeness: > > > >These two patches each add an xtables match. > > > >The xt_priority match is a straighforward addition in the style of > >xt_mark, adding the option to filter on one more sk_buff field. I > >have an immediate application for this. The amount of code (in > >kernel + userspace) to add a single check proved quite large. > > Hm so yeah, can't we just place this in xt_mark.c? I don't feel this belongs to xt_mark at all.