From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Bob Hockney <bhockney@ix.netcom.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nfnetlink_log mac address for 6in4 tunnels
Date: Sun, 16 Dec 2012 23:47:47 +0100 [thread overview]
Message-ID: <20121216224747.GA4167@1984> (raw)
In-Reply-To: <000601cdd958$76ea7a00$64bf6e00$@ix.netcom.com>
On Thu, Dec 13, 2012 at 10:37:02AM -0700, Bob Hockney wrote:
>
> For tunneled ipv6in4 packets, the LOG target (xt_LOG.c) adjusts the start of
> the mac field to start at the ethernet header instead of the ipv4 header for
> the tunnel. This patch conforms what is passed by the NFLOG target through
> nfnetlink to what the LOG target does. Code borrowed from xt_LOG.c.
>
> Here are before and after log lines. The kernel: lines are with the LOG
> target, the ulogd lines are with NFLOG, ulogd and its SYSLOG plugin:
>
> Log lines for the same packet, before patch:
>
> Dec 3 09:07:22 gateway kernel: [ 69.268396] INVALID IN=he-ipv6 OUT=eth1
> MAC=00:50:8d:bf:02:01:68:ef:bd:f0:7d:d9:08:00:45:00:00:5c:00:00:40:00:fa:29:
> 64:c2:42:dc:12:2a:18:31:ae:7f TUNNEL=66.220.18.42->w.x.y.z SRC= ...
> Dec 3 09:07:22 gateway ulogd[1628]: INVALID IN=he-ipv6 OUT=eth1
> MAC=45:00:00:5c:00:00:40:00:fa:29:64:c2:42:dc:12:2a:18:31:ae:7f:68:00:00:00:
> 00:20:06:35:2a:03:28:80:00:10 SRC= ...
>
> Log lines after patch:
>
> Dec 3 09:08:44 gateway kernel: [ 32.998288] INVALID IN=he-ipv6 OUT=eth1
> MAC=00:50:8d:bf:02:01:68:ef:bd:f0:7d:d9:08:00:45:00:00:5c:00:00:40:00:fa:29:
> 64:c2:42:dc:12:2a:18:31:ae:7f TUNNEL=66.220.18.42->w.x.y.z SRC= ...
> Dec 3 09:08:45 gateway ulogd[1488]: INVALID IN=he-ipv6 OUT=eth1
> MAC=00:50:8d:bf:02:01:68:ef:bd:f0:7d:d9:08:00:45:00:00:5c:00:00:40:00:fa:29:
> 64:c2:42:dc:12:2a:18:31:ae:7f SRC= ...
Applied.
Please, next time you have to base your patch on some recent linux
kernel tree. You can get it via git or just some snapshot via
kernel.org, I'm telling this because I had to rebase this patch upon
current.
Thanks Bob.
next prev parent reply other threads:[~2012-12-16 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 17:37 [PATCH] nfnetlink_log mac address for 6in4 tunnels Bob Hockney
2012-12-16 22:47 ` Pablo Neira Ayuso [this message]
2012-12-17 2:29 ` Bob Hockney
-- strict thread matches above, loose matches on Subject: below --
2012-12-05 18:05 Bob Hockney
2012-12-11 11:33 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121216224747.GA4167@1984 \
--to=pablo@netfilter.org \
--cc=bhockney@ix.netcom.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).