From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Vitaly E. Lavrov" <lve@guap.ru>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] xt_recent fix BUG()
Date: Sun, 16 Dec 2012 23:50:25 +0100 [thread overview]
Message-ID: <20121216225025.GB4167@1984> (raw)
In-Reply-To: <50C78438.4040102@guap.ru>
Hi Vitaly,
On Tue, Dec 11, 2012 at 11:06:32PM +0400, Vitaly E. Lavrov wrote:
> The following patch fixes a bug in xt_recent.
> Bug appears at the end of work the networks namespace, provided that
> the tables (filter/mangle/raw) have rule with xt_recent.
> The error occurs because the __net_exit recent_net_exit() is
> executed before the tables are cleared.
> Change this order of calls is impossible, since tables must be
> registered earlier than extensions.
> Bug exists in all versions of the kernel since 2.6.35
>
> Cleaning tables before completing the network namespace can be used
> as a workaround.
>
> Idea of the patch that if the files are deleted from the directory
> /proc/net/xt_recent" procedure XXXXX, then a flag is set "clean".
> If cleaning the tables occurs later and the flag "clean" is set,
> then the delete files is skipped.
>
> Patch for kernel 3.4.22
I need that the patch applies to some more recent kernel tree.
Same comment for the hashlimit fix.
Could you send me a new round rebased upon it, please? Thanks.
prev parent reply other threads:[~2012-12-16 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 19:06 [PATCH] xt_recent fix BUG() Vitaly E. Lavrov
2012-12-16 22:50 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121216225025.GB4167@1984 \
--to=pablo@netfilter.org \
--cc=lve@guap.ru \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).