From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] build: unbreak linkage of m_xt.so Date: Tue, 18 Dec 2012 09:21:30 -0800 Message-ID: <20121218092130.1d3f4239@nehalam.linuxnetplumber.net> References: <1355617968-26138-1-git-send-email-jengelh@inai.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: stephen.hemminger@vyatta.com, vapier@gentoo.org, netdev@vger.kernel.org, jhs@mojatatu.com, urykhy@gmail.com, shemonc@gmail.com, pablo@netfilter.org, netfilter-devel@vger.kernel.org To: Jan Engelhardt Return-path: Received: from mail.vyatta.com ([76.74.103.46]:57742 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754609Ab2LRRXe (ORCPT ); Tue, 18 Dec 2012 12:23:34 -0500 In-Reply-To: <1355617968-26138-1-git-send-email-jengelh@inai.de> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sun, 16 Dec 2012 01:32:48 +0100 Jan Engelhardt wrote: > Commit v3.7.0~10 caused the variable new PKG_CONFIG variable never > to be present at the time of calling make, leading to tc/m_xt.so > not linked with -lxtables (result from pkg-config xtables --libs), > that in turn leading to > > tc: symbol lookup error: /usr/lib64/tc//m_xt.so: undefined symbol: > xtables_init_all > > Fixing that. > > Signed-off-by: Jan Engelhardt > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 9912114..573ee55 100755 > --- a/configure > +++ b/configure > @@ -4,7 +4,6 @@ > INCLUDE=${1:-"$PWD/include"} > : ${PKG_CONFIG:=pkg-config} > : ${CC=gcc} > -echo "PKG_CONFIG:=${PKG_CONFIG}" >>Config > > # Make a temp directory in build tree. > TMPDIR=$(mktemp -d config.XXXXXX) > @@ -224,6 +223,7 @@ rm -f $TMPDIR/ipsettest.c $TMPDIR/ipsettest > } > > echo "# Generated config based on" $INCLUDE >Config > +echo "PKG_CONFIG:=${PKG_CONFIG}" >>Config > > echo "TC schedulers" > Ok, manually did the diff (conflicted with other previous changes).