netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
	netfilter-devel <netfilter-devel@vger.kernel.org>,
	Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: NOTRACK removal breaks working configurations
Date: Thu, 20 Dec 2012 13:28:39 +0100	[thread overview]
Message-ID: <20121220122839.GD17461@breakpoint.cc> (raw)
In-Reply-To: <20121220115451.GA31838@1984>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > commit 965505015beccc4ec900798070165875b8e8dccf
> > Author: Cong Wang <xiyou.wangcong@gmail.com>
> > Subject: netfilter: remove xt_NOTRACK
> > 
> > It breaks working netfilter configurations.
> > At the very least, NOTRACK should have printk'd
> > 
> > BIG FAT REMOVAL WARNING
> > 
> > for a year or so.  Which it didn't do.
> 
> This was announced in Documentation/feature-removal-schedule.txt and
> the aliasing infrastructure was added to iptables

I know.

> it was agressive since I think not many users have checked that file /
> they may no have upgrade iptables to latest.

Right.

> Can you see any problem with the patch attached?

No.  The patch works.
[   21.870092] xt_CT: netfilter: NOTRACK target is deprecated, use CT instead or upgrade iptables

Even better than a revert.

Thanks,
Florian

  reply	other threads:[~2012-12-20 12:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 10:23 NOTRACK removal breaks working configurations Florian Westphal
2012-12-20 11:54 ` Pablo Neira Ayuso
2012-12-20 12:28   ` Florian Westphal [this message]
2012-12-20 13:02     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121220122839.GD17461@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).