From: Florian Westphal <fw@strlen.de>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnetfilter_conntrack PATCH] Fix logic typo in cmp_secctx
Date: Thu, 27 Dec 2012 15:29:55 +0100 [thread overview]
Message-ID: <20121227142955.GB11727@breakpoint.cc> (raw)
In-Reply-To: <4631253.eD7KB7KPU6@storm>
Thomas Jarosch <thomas.jarosch@intra2net.com> wrote:
> cppcheck reported:
> [src/conntrack/compare.c:364] -> [src/conntrack/compare.c:364]: (style) Same expression on both sides of '||'.
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
> src/conntrack/compare.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conntrack/compare.c b/src/conntrack/compare.c
> index b18f7fc..e282a24 100644
> --- a/src/conntrack/compare.c
> +++ b/src/conntrack/compare.c
> @@ -361,7 +361,7 @@ cmp_secctx(const struct nf_conntrack *ct1,
> const struct nf_conntrack *ct2,
> unsigned int flags)
> {
> - if (ct1->secctx == NULL || ct1->secctx == NULL)
> + if (ct1->secctx == NULL || ct2->secctx == NULL)
Grrr, my fault.
Applied, thanks for fixing this.
prev parent reply other threads:[~2012-12-27 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 14:12 [libnetfilter_conntrack PATCH] Fix logic typo in cmp_secctx Thomas Jarosch
2012-12-27 14:29 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121227142955.GB11727@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).