From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 01/19] netfilter: move nf_conntrack initialize out of pernet operations Date: Fri, 28 Dec 2012 12:58:01 +0100 Message-ID: <20121228115801.GA20120@1984> References: <1356662206-2260-1-git-send-email-gaofeng@cn.fujitsu.com> <87ip7mlr2r.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: canqun zhang , Gao feng , netfilter-devel@vger.kernel.org, "netdev@vger.kernel.org" , Patrick McHardy To: "Eric W. Biederman" Return-path: Received: from mail.us.es ([193.147.175.20]:51734 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753611Ab2L1L6G (ORCPT ); Fri, 28 Dec 2012 06:58:06 -0500 Content-Disposition: inline In-Reply-To: <87ip7mlr2r.fsf@xmission.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, Dec 27, 2012 at 08:48:44PM -0800, Eric W. Biederman wrote: [...] > Does anyone know why Alexy decided to do this only for init_net? Not myself. [...] > My inclination is that Gao Feng is on the rigt path by just removing > the strange init_net special case and performing the work once > per module load, and once per module unload. That makes sense to me, I'll check Gao's patchset asap to come back to him with some feedback. Thanks.