* [PATCH] netfilter: add include file to nf_conntrack_snmp.c
@ 2012-12-29 4:17 Stephen Hemminger
2013-01-17 23:36 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2012-12-29 4:17 UTC (permalink / raw)
To: Pablo Neira Ayuso, David Miller, netfilter-devel
Prototype for nf_nat_snmp_hook is in nf_conntrack_snmp.h therefore
it should be included to get type checking. Found by sparse.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/netfilter/nf_conntrack_snmp.c 2012-10-25 09:11:15.711271681 -0700
+++ b/net/netfilter/nf_conntrack_snmp.c 2012-12-28 20:09:04.666030725 -0800
@@ -16,6 +16,7 @@
#include <net/netfilter/nf_conntrack.h>
#include <net/netfilter/nf_conntrack_helper.h>
#include <net/netfilter/nf_conntrack_expect.h>
+#include <linux/netfilter/nf_conntrack_snmp.h>
#define SNMP_PORT 161
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: add include file to nf_conntrack_snmp.c
2012-12-29 4:17 [PATCH] netfilter: add include file to nf_conntrack_snmp.c Stephen Hemminger
@ 2013-01-17 23:36 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-01-17 23:36 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, netfilter-devel
On Fri, Dec 28, 2012 at 08:17:08PM -0800, Stephen Hemminger wrote:
> Prototype for nf_nat_snmp_hook is in nf_conntrack_snmp.h therefore
> it should be included to get type checking. Found by sparse.
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-17 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-29 4:17 [PATCH] netfilter: add include file to nf_conntrack_snmp.c Stephen Hemminger
2013-01-17 23:36 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).