* Re: [PATCH] net: fix checking boundary of valid vlan id
[not found] <1356848931-22193-1-git-send-email-akong@redhat.com>
@ 2013-01-03 0:39 ` Pablo Neira Ayuso
2013-01-03 20:06 ` Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2013-01-03 0:39 UTC (permalink / raw)
To: akong; +Cc: netdev, davem, Netfilter Development Mailing list
On Sun, Dec 30, 2012 at 02:28:51PM +0800, akong@redhat.com wrote:
> From: Amos Kong <akong@redhat.com>
>
> 4096 is not a valid vlan id.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> net/bridge/netfilter/ebt_vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebt_vlan.c b/net/bridge/netfilter/ebt_vlan.c
> index eae67bf..b279ec0 100644
> --- a/net/bridge/netfilter/ebt_vlan.c
> +++ b/net/bridge/netfilter/ebt_vlan.c
> @@ -121,8 +121,8 @@ static int ebt_vlan_mt_check(const struct xt_mtchk_param *par)
> * if_vlan.h: VLAN_N_VID 4096. */
> if (GET_BITMASK(EBT_VLAN_ID)) {
> if (!!info->id) { /* if id!=0 => check vid range */
> - if (info->id > VLAN_N_VID) {
> - pr_debug("id %d is out of range (1-4096)\n",
> + if (info->id >= VLAN_N_VID) {
> + pr_debug("id %d is out of range (1-4095)\n",
Someone may forge frames including reserved VLAN ids.
People can use ebtables to drop invalid frames, this is a firewalling
utility after all ;-). I'm not taking these, sorry.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: fix checking boundary of valid vlan id
2013-01-03 0:39 ` [PATCH] net: fix checking boundary of valid vlan id Pablo Neira Ayuso
@ 2013-01-03 20:06 ` Ben Hutchings
0 siblings, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2013-01-03 20:06 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: akong, netdev, davem, Netfilter Development Mailing list
On Thu, 2013-01-03 at 01:39 +0100, Pablo Neira Ayuso wrote:
> On Sun, Dec 30, 2012 at 02:28:51PM +0800, akong@redhat.com wrote:
> > From: Amos Kong <akong@redhat.com>
> >
> > 4096 is not a valid vlan id.
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > ---
> > net/bridge/netfilter/ebt_vlan.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/net/bridge/netfilter/ebt_vlan.c b/net/bridge/netfilter/ebt_vlan.c
> > index eae67bf..b279ec0 100644
> > --- a/net/bridge/netfilter/ebt_vlan.c
> > +++ b/net/bridge/netfilter/ebt_vlan.c
> > @@ -121,8 +121,8 @@ static int ebt_vlan_mt_check(const struct xt_mtchk_param *par)
> > * if_vlan.h: VLAN_N_VID 4096. */
> > if (GET_BITMASK(EBT_VLAN_ID)) {
> > if (!!info->id) { /* if id!=0 => check vid range */
> > - if (info->id > VLAN_N_VID) {
> > - pr_debug("id %d is out of range (1-4096)\n",
> > + if (info->id >= VLAN_N_VID) {
> > + pr_debug("id %d is out of range (1-4095)\n",
>
> Someone may forge frames including reserved VLAN ids.
They may find it difficult to fit the value 4096 into a 12-bit field,
though.
Ben.
> People can use ebtables to drop invalid frames, this is a firewalling
> utility after all ;-). I'm not taking these, sorry.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net: fix checking boundary of valid vlan id
@ 2012-12-30 9:21 akong
0 siblings, 0 replies; 3+ messages in thread
From: akong @ 2012-12-30 9:21 UTC (permalink / raw)
To: netfilter-devel; +Cc: pablo, kaber
From: Amos Kong <akong@redhat.com>
According to IEEE 802.1Q, 4096 is not a valid vlan id, 4095 is reserved.
Signed-off-by: Amos Kong <akong@redhat.com>
---
net/bridge/netfilter/ebt_vlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/netfilter/ebt_vlan.c b/net/bridge/netfilter/ebt_vlan.c
index eae67bf..5bdebc3 100644
--- a/net/bridge/netfilter/ebt_vlan.c
+++ b/net/bridge/netfilter/ebt_vlan.c
@@ -121,8 +121,8 @@ static int ebt_vlan_mt_check(const struct xt_mtchk_param *par)
* if_vlan.h: VLAN_N_VID 4096. */
if (GET_BITMASK(EBT_VLAN_ID)) {
if (!!info->id) { /* if id!=0 => check vid range */
- if (info->id > VLAN_N_VID) {
- pr_debug("id %d is out of range (1-4096)\n",
+ if (info->id >= VLAN_N_VID - 1) {
+ pr_debug("id %d is out of range (1-4094)\n",
info->id);
return -EINVAL;
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-03 20:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1356848931-22193-1-git-send-email-akong@redhat.com>
2013-01-03 0:39 ` [PATCH] net: fix checking boundary of valid vlan id Pablo Neira Ayuso
2013-01-03 20:06 ` Ben Hutchings
2012-12-30 9:21 akong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).