From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Miroslav Kratochvil <exa.exa@gmail.com>,
h.reindl@thelounge.net, Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] netfilter: xt_recent: avoid high order page allocations
Date: Fri, 4 Jan 2013 20:23:16 +0100 [thread overview]
Message-ID: <20130104192316.GA17714@1984> (raw)
In-Reply-To: <1357287519.1678.70.camel@edumazet-glaptop>
On Fri, Jan 04, 2013 at 12:18:39AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> xt_recent can try high order page allocations and this can fail.
>
> iptables: page allocation failure: order:9, mode:0xc0d0
>
> It also wastes about half the allocated space because of kmalloc()
> power-of-two roundups and struct recent_table layout.
>
> Use vmalloc() instead to save space and be less prone to allocation
> errors when memory is fragmented.
Applied, thanks Eric!
prev parent reply other threads:[~2013-01-04 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 8:18 [PATCH] netfilter: xt_recent: avoid high order page allocations Eric Dumazet
2013-01-04 19:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130104192316.GA17714@1984 \
--to=pablo@netfilter.org \
--cc=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=exa.exa@gmail.com \
--cc=h.reindl@thelounge.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).