netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: vapier@gentoo.org, netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [PATCH] build: resolve link failure for ip6t_NETMAP
Date: Sat, 12 Jan 2013 04:00:54 +0400	[thread overview]
Message-ID: <20130112000054.GA20139@altlinux.org> (raw)
In-Reply-To: <20130111233430.GA18124@altlinux.org>

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On Sat, Jan 12, 2013 at 03:34:30AM +0400, Dmitry V. Levin wrote:
> Hi,
> 
> On Wed, Jan 02, 2013 at 09:47:51AM +0100, Jan Engelhardt wrote:
> [...]
> > --- a/extensions/GNUmakefile.in
> > +++ b/extensions/GNUmakefile.in
> [...]
> > @@ -75,7 +76,7 @@ install: ${targets_install}
> >  	if test -n "${targets_install}"; then install -pm0755 $^ "${DESTDIR}${xtlibdir}/"; fi;
> 
> No, this is a regression.  If ${targets_install} shared objects are made
> by libtool, they are intermediate files not expected to be installed by
> hand (due to funny RPATHs and so on), so they have to be installed by
> libtool --mode=install.
> 
> Something like
> 	for f in $^; do ../libtool ${AM_LIBTOOL_SILENT} --tag=CC --mode=install ${INSTALL} -pm0755 $${f/.so/.la} "${DESTDIR}${xtlibdir}/"; done
> would work.

No, it didn't work because of ${pfx_symlinks} modules which are not
libtool files.  I've managed to build it with a more complex yet reliable
rule:

	for f in $^; do la="$${f/.so/.la}"; if test -f "$$la"; then ../libtool ${AM_LIBTOOL_SILENT} --tag=CC --mode=install ${INSTALL} -pm0755 "$$la" "${DESTDIR}${xtlibdir}/"; elif test -L "$$f"; then cp -a "$$f" "${DESTDIR}${xtlibdir}/"; else exit 1; fi || exit; done


-- 
ldv

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2013-01-12  0:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-30 23:11 [PATCH] extensions: fix linking against -lip6tc Mike Frysinger
2012-12-30 23:38 ` Pablo Neira Ayuso
2012-12-31  0:51   ` Mike Frysinger
2012-12-31  5:54     ` [PATCH] build: resolve link failure for ip6t_NETMAP Jan Engelhardt
2013-01-02  4:03       ` Mike Frysinger
2013-01-02  8:42         ` Jan Engelhardt
2013-01-02  8:47           ` Jan Engelhardt
2013-01-02 17:23             ` Mike Frysinger
2013-01-02 23:50               ` Pablo Neira Ayuso
2013-01-11 23:34             ` Dmitry V. Levin
2013-01-12  0:00               ` Dmitry V. Levin [this message]
2013-01-12  1:37               ` Jan Engelhardt
  -- strict thread matches above, loose matches on Subject: below --
2012-12-02 18:16 Jan Engelhardt
2012-12-03 13:12 ` Pablo Neira Ayuso
2012-12-03 15:58   ` Jan Engelhardt
2012-12-04 12:16     ` Pablo Neira Ayuso
2012-12-04 13:42       ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130112000054.GA20139@altlinux.org \
    --to=ldv@altlinux.org \
    --cc=jengelh@inai.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).