From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: x_tables: print correct hook names for ARP
Date: Sun, 13 Jan 2013 16:07:38 +0100 [thread overview]
Message-ID: <20130113150738.GA32515@1984> (raw)
In-Reply-To: <1357857005-2825-1-git-send-email-jengelh@inai.de>
On Thu, Jan 10, 2013 at 11:30:05PM +0100, Jan Engelhardt wrote:
> arptables 0.0.4 supports calling the CLASSIFY target, but on adding a
> rule to the wrong chain, the diagnostic is as follows:
>
> # arptables -A INPUT -j CLASSIFY --set-class 0:0
> arptables: Invalid argument
> # dmesg | tail -n1
> x_tables: arp_tables: CLASSIFY target: used from hooks
> PREROUTING, but only usable from INPUT/FORWARD
>
> This is incorrect, since xt_CLASSIFY.c does specify
> (1 << NF_ARP_OUT) | (1 << NF_ARP_FORWARD).
>
> This patch corrects the x_tables diagnostic message to print the
> proper hook names for the NFPROTO_ARP case.
I have applied this patch to the nf tree.
prev parent reply other threads:[~2013-01-13 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 22:30 [PATCH] netfilter: x_tables: print correct hook names for ARP Jan Engelhardt
2013-01-13 15:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130113150738.GA32515@1984 \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).