From: Florian Westphal <fw@strlen.de>
To: Jean-Michel DILLY <jm@dilly.me>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix IPv6 NTP checksum calculation
Date: Thu, 24 Jan 2013 23:49:24 +0100 [thread overview]
Message-ID: <20130124224924.GH8541@breakpoint.cc> (raw)
In-Reply-To: <06023CFA-4D28-43B3-8C7F-B8223F3390DD@dilly.me>
Jean-Michel DILLY <jm@dilly.me> wrote:
> Hi all,
> This patch doesn't work as expected. I tried with few IP and each time 0x0100 were missing. csum_add seems buggy too.
> I have reimplemented csum16s functions with the Ulrich's fix. It seems to work now.
> I'm a noob, so I guess someone will propose a better patch for this.
We can't use csum_add after all, patch looks correct.
Can you re-send with proper Signoff?
[ carry detection breaks on overflow, e.g. a==1 and b=0xffff yields
0 for csum_add (65536 < 1) and 1 for csum16_add (0 < 1) ]
next prev parent reply other threads:[~2013-01-24 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 17:09 [PATCH] netfilter: fix IPv6 NTP checksum calculation Jean-Michel DILLY
2013-01-24 22:49 ` Florian Westphal [this message]
2013-01-25 21:09 ` Jean-Michel DILLY
2013-01-26 16:29 ` YOSHIFUJI Hideaki
2013-01-29 14:50 ` Ulrich Weber
-- strict thread matches above, loose matches on Subject: below --
2013-01-02 15:24 Ulrich Weber
2013-01-04 9:20 ` Patrick McHardy
2013-01-04 19:22 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124224924.GH8541@breakpoint.cc \
--to=fw@strlen.de \
--cc=jm@dilly.me \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).