From: Florian Westphal <fw@strlen.de>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Florian Westphal <fw@strlen.de>,
Rafal Kupka <rkupka@telemetry.com>,
netdev@vger.kernel.org,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: BUG: unable to handle kernel paging request at 0000000000609920 in networking code on 3.2.23.
Date: Fri, 25 Jan 2013 09:28:39 +0100 [thread overview]
Message-ID: <20130125082839.GJ8541@breakpoint.cc> (raw)
In-Reply-To: <alpine.LNX.2.01.1301250124310.21495@nerf07.vanv.qr>
Jan Engelhardt <jengelh@inai.de> wrote:
> On Friday 2013-01-25 00:08, Florian Westphal wrote:
> >@@ -35,10 +35,18 @@ tcpoptstrip_mangle_packet(struct sk_buff *skb,
> > {
> > unsigned int optl, i, j;
> > struct tcphdr *tcph;
> >+ struct tcphdr _tcph;
> > u_int16_t n, o;
> > u_int8_t *opt;
> >
> >- if (!skb_make_writable(skb, skb->len))
> >+ if (skb->len < minlen)
> >+ return XT_CONTINUE;
> >+
> >+ tcph = skb_header_pointer(skb, tcphoff, sizeof(_tcph), &_tcph);
> >+ if (!tcph)
> >+ return XT_CONTINUE; /* no options -> nothing to do */
>
> To the best of my analysis, the "no options" comment is incorrect here,
> because you are not even looking at the options so far, but only tcph.
Yup.
> The prose should probably be something like:
> if (iph->frag_off & htons(IP_OFFSET)) != 0)
> /* not the first fragment - lost case */
> return XT_CONTINUE;
[..]
Can to submit a patch?
prev parent reply other threads:[~2013-01-25 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <A60E26F6-16DC-4A29-BFDE-1B17DC51F64F@telemetry.com>
[not found] ` <loom.20130124T115328-292@post.gmane.org>
2013-01-24 23:08 ` BUG: unable to handle kernel paging request at 0000000000609920 in networking code on 3.2.23 Florian Westphal
2013-01-25 0:36 ` Jan Engelhardt
2013-01-25 8:28 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125082839.GJ8541@breakpoint.cc \
--to=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rkupka@telemetry.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).