From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 7/7] netfilter: nf_ct_helper: Fix logging for dropped packets
Date: Tue, 19 Feb 2013 21:17:49 +0100 [thread overview]
Message-ID: <20130219201748.GG3319@localhost> (raw)
In-Reply-To: <1361260267.5920.15.camel@joe-AO722>
On Mon, Feb 18, 2013 at 11:51:07PM -0800, Joe Perches wrote:
>
> Sorry, I didn't look at the function implementation.
>
> It doesn't use the var args that follow fmt.
> Two current uses have format and args aren't emitted correctly.
Thanks Joe, will pass this to David asap.
Regards.
next prev parent reply other threads:[~2013-02-19 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 0:10 [PATCH 0/7] netfilter updates for net-next pablo
2013-02-19 0:10 ` [PATCH 1/7] netfilter: fix missing dependencies for NETFILTER_XT_MATCH_CONNLABEL pablo
2013-02-19 0:10 ` [PATCH 2/7] netfilter: xt_conntrack: Add flag to support aliases pablo
2013-02-19 0:10 ` [PATCH 3/7] netfilter: xt_CT: merge common code of revision 0 and 1 pablo
2013-02-19 0:10 ` [PATCH 4/7] netfilter: xt_CT: add alias flag pablo
2013-02-19 0:10 ` [PATCH 5/7] netfilter: nfnetlink: add mutex per subsystem pablo
2013-02-19 0:10 ` [PATCH 6/7] netfilter: nf_ct_pptp: Fix comment referring to incorrect RFC pablo
2013-02-19 0:10 ` [PATCH 7/7] netfilter: nf_ct_helper: better logging for dropped packets pablo
2013-02-19 0:22 ` Joe Perches
2013-02-19 1:11 ` Pablo Neira Ayuso
2013-02-19 1:23 ` Joe Perches
2013-02-19 1:43 ` Pablo Neira Ayuso
2013-02-19 1:33 ` Joe Perches
2013-02-19 1:50 ` Pablo Neira Ayuso
2013-02-19 7:51 ` [PATCH 7/7] netfilter: nf_ct_helper: Fix " Joe Perches
2013-02-19 20:17 ` Pablo Neira Ayuso [this message]
2013-02-19 5:44 ` [PATCH 0/7] netfilter updates for net-next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219201748.GG3319@localhost \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).