From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@inai.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/6] build: also use libtool for install stage
Date: Wed, 6 Mar 2013 15:08:36 +0400 [thread overview]
Message-ID: <20130306110836.GA4017@altlinux.org> (raw)
In-Reply-To: <20130205033007.GA20407@localhost>
[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]
On Tue, Feb 05, 2013 at 04:30:07AM +0100, Pablo Neira Ayuso wrote:
> On Mon, Jan 28, 2013 at 02:59:41PM +0100, Jan Engelhardt wrote:
> > The just-built library has DT_RPATH entries to be runnable from
> > whereever it is. If we just install that, the distro build systems
> > will throw warnings like
> >
> > (Open Build Service) ERROR: RPATH
> > "/home/abuild/rpmbuild/BUILD/iptables-1.4.17a/libxtables/.libs"
> > on /home/abuild/rpmbuild/BUILDROOT/iptables-1.4.17a-0.x86_64/usr/lib64/xtables/libxt_unclean.so
> > is not allowed
> >
> > These RPATH entries are indeed undesired for libraries is in a system
> > location, which is why libtool produces another copy of the library on
> > installation. The makefile however missed using libtool during
> > installation (introduced with commit v1.4.17-1-g68e77a2).
> > This patch now resolves this.
> >
> > There will be extra "warnings" emitted by libtool during `make install`,
> > like:
> >
> > libtool: install: warning: relinking "libxt_AUDIT.la"
> >
> > This is normal (and unfixable)
>
> I prefer that distros live with that warning. Users will be annoyed by
> that warning for sure.
There is a clear misunderstanding on your side, a RPATH entry containing
buildroot is a FATAL ERROR that distro maintainers have to fix just to
release new builds of iptables package. The question is how long distro
maintainers would have to reinvent the wheel and rebase these build fixes
onto new iptables releases. To be honest, I was much surprised to find
out that these build fixes didn't get into 1.4.18.
With regards to libtool's warnings about relinking, it happens to all
hundreds of packages that manipulate RPATH entries during build, so
the amount of annoyance among libtool users would hardly increase.
--
ldv
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-03-06 11:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 13:59 Accumulated fixes v2 Jan Engelhardt
2013-01-28 13:59 ` [PATCH 1/6] build: also use libtool for install stage Jan Engelhardt
2013-02-05 3:30 ` Pablo Neira Ayuso
2013-03-05 23:16 ` Jan Engelhardt
2013-03-06 11:08 ` Dmitry V. Levin [this message]
2013-03-07 20:39 ` Jan Engelhardt
2013-03-19 23:42 ` Pablo Neira Ayuso
2013-01-28 13:59 ` [PATCH 2/6] build: do not dereference symlinks on installation Jan Engelhardt
2013-01-28 13:59 ` [PATCH 3/6] libxtables: centralize checking for a .save function Jan Engelhardt
2013-01-28 13:59 ` [PATCH 4/6] extensions: eui64: set userspacesize=0 Jan Engelhardt
2013-01-28 13:59 ` [PATCH 5/6] iptables: fall back to using save function when print is not defined Jan Engelhardt
2013-01-28 13:59 ` [PATCH 6/6] iptables: reword warning on using an alias Jan Engelhardt
2013-01-31 2:13 ` Accumulated fixes v2 Jan Engelhardt
2013-01-31 9:41 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306110836.GA4017@altlinux.org \
--to=ldv@altlinux.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).