* [PATCH] ipv4: netfilter: use PTR_RET instead of IS_ERR + PTR_ERR
@ 2013-03-12 18:07 Silviu-Mihai Popescu
2013-03-15 11:48 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Silviu-Mihai Popescu @ 2013-03-12 18:07 UTC (permalink / raw)
To: netfilter-devel
Cc: pablo, kaber, davem, kuznet, jmorris, yoshfuji, coreteam, netdev,
linux-kernel, Silviu-Mihai Popescu
This uses PTR_RET instead of IS_ERR and PTR_ERR in order to increase
readability.
Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
net/ipv4/netfilter/arptable_filter.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/ipv4/netfilter/arptable_filter.c b/net/ipv4/netfilter/arptable_filter.c
index 79ca5e7..eadab1e 100644
--- a/net/ipv4/netfilter/arptable_filter.c
+++ b/net/ipv4/netfilter/arptable_filter.c
@@ -48,9 +48,7 @@ static int __net_init arptable_filter_net_init(struct net *net)
net->ipv4.arptable_filter =
arpt_register_table(net, &packet_filter, repl);
kfree(repl);
- if (IS_ERR(net->ipv4.arptable_filter))
- return PTR_ERR(net->ipv4.arptable_filter);
- return 0;
+ return PTR_RET(net->ipv4.arptable_filter);
}
static void __net_exit arptable_filter_net_exit(struct net *net)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv4: netfilter: use PTR_RET instead of IS_ERR + PTR_ERR
2013-03-12 18:07 [PATCH] ipv4: netfilter: use PTR_RET instead of IS_ERR + PTR_ERR Silviu-Mihai Popescu
@ 2013-03-15 11:48 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-03-15 11:48 UTC (permalink / raw)
To: Silviu-Mihai Popescu
Cc: netfilter-devel, kaber, davem, kuznet, jmorris, yoshfuji,
coreteam, netdev, linux-kernel
On Tue, Mar 12, 2013 at 08:07:55PM +0200, Silviu-Mihai Popescu wrote:
> This uses PTR_RET instead of IS_ERR and PTR_ERR in order to increase
> readability.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-15 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-12 18:07 [PATCH] ipv4: netfilter: use PTR_RET instead of IS_ERR + PTR_ERR Silviu-Mihai Popescu
2013-03-15 11:48 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).