From: Michal Kubecek <mkubecek@suse.cz>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: Can we rely on ethernet header padding?
Date: Wed, 20 Mar 2013 10:54:26 +0100 [thread overview]
Message-ID: <20130320095426.GA20373@unicorn.suse.cz> (raw)
In-Reply-To: <20130319142553.3e08e7b9@nehalam.linuxnetplumber.net>
On Tue, Mar 19, 2013 at 02:25:53PM -0700, Stephen Hemminger wrote:
>
> My view is that the bridge code must check before assuming headroom.
> But because of that, it means a packet copy would be necessary for cases
> where packets arrive without enough headroom.
Yes, but for most users this is better than a crash. How about issuing a
WARN_ONCE() in such case so that we avoid writing out of the buffer but
still allow developers (and users who check logs) to catch the problem?
Michal Kubecek
prev parent reply other threads:[~2013-03-20 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 15:05 Can we rely on ethernet header padding? Michal Kubecek
2013-03-19 15:21 ` Eric Dumazet
2013-03-19 15:48 ` Michal Kubecek
2013-03-19 21:25 ` Stephen Hemminger
2013-03-20 9:54 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320095426.GA20373@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).