netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: David Miller <davem@davemloft.net>
Cc: dev@openvswitch.org, isdn@linux-pingi.de,
	bridge@lists.linux-foundation.org, johan.hedberg@gmail.com,
	gustavo@padovan.org, marcel@holtmann.org, jesse@nicira.com,
	linux-wireless@vger.kernel.org, stephen@networkplumber.org,
	linux-bluetooth@vger.kernel.org, bart.de.schuymer@pandora.be,
	netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	johannes@sipsolutions.net, linux1394-devel@lists.sourceforge.net,
	kaber@trash.net, linux-media@vger.kernel.org
Subject: Re: [PATCH v2] net: add ETH_P_802_3_MIN
Date: Thu, 28 Mar 2013 14:31:29 +0900	[thread overview]
Message-ID: <20130328053128.GA23630@verge.net.au> (raw)
In-Reply-To: <20130328.012108.961738246524996742.davem@davemloft.net>

On Thu, Mar 28, 2013 at 01:21:08AM -0400, David Miller wrote:
> From: Simon Horman <horms@verge.net.au>
> Date: Thu, 28 Mar 2013 13:38:25 +0900
> 
> > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for
> > an 802.3 frame. Frames with a lower value in the ethernet type field
> > are Ethernet II.
> > 
> > Also update all the users of this value that David Miller and
> > I could find to use the new constant.
> > 
> > Also correct a bug in util.c. The comparison with ETH_P_802_3_MIN
> > should be >= not >.
> > 
> > As suggested by Jesse Gross.
> > 
> > Compile tested only.
> > 
> > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> > Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> 
> Looks great, applied, thanks Simon.

Thanks!

      reply	other threads:[~2013-03-28  5:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  4:38 [PATCH v2] net: add ETH_P_802_3_MIN Simon Horman
     [not found] ` <1364445505-9745-1-git-send-email-horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-03-28  5:21   ` David Miller
2013-03-28  5:31     ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130328053128.GA23630@verge.net.au \
    --to=horms@verge.net.au \
    --cc=bart.de.schuymer@pandora.be \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=gustavo@padovan.org \
    --cc=isdn@linux-pingi.de \
    --cc=jesse@nicira.com \
    --cc=johan.hedberg@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=kaber@trash.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).