From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] NFQUEUE: add --queue-cpu-fanout parameter
Date: Tue, 2 Apr 2013 13:26:32 +0200 [thread overview]
Message-ID: <20130402112632.GA9386@localhost> (raw)
In-Reply-To: <20130402103539.GF8327@imap.eitzenberger.org>
Hi Holger,
On Tue, Apr 02, 2013 at 12:35:39PM +0200, Holger Eitzenberger wrote:
> Hi Pablo,
>
> > I think we have to add O_QUEUE_CPU_FANOUT here to make sure both
> > queue-balance and queue-cpu-fanout are not used both incorrectly
> > together. That also needs some code a new .x6_fcheck function to
> > validate this.
>
> it is currently that --queue-cpu-fanout *requires* --queue-balance, as
> the CPU fanout works on top of the balanced queues.
>
> Or possibly I miss your point.
Forget it, your patch was just fine, sorry.
> > Could you also send me the corresponding manpage update for this?
>
> Sorry for lacking that.
>
> I've respinned the 3/3 patch to include the man page update as well.
Thanks!
I have pushed this to the -next branch of iptables. Will merge by when
3.10-rc1 is released.
prev parent reply other threads:[~2013-04-02 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 20:04 [PATCH v2 0/3] NFQUEUE: introduce CPU fanout Holger Eitzenberger
2013-03-23 20:04 ` [PATCH v2 1/3] " Holger Eitzenberger
2013-04-01 23:26 ` Pablo Neira Ayuso
2013-03-23 20:04 ` [PATCH v2 2/3] NFQUEUE: coalesce IPv4 and IPv6 hashing Holger Eitzenberger
2013-04-01 23:26 ` Pablo Neira Ayuso
2013-03-23 20:04 ` [PATCH v2 3/3] NFQUEUE: add --queue-cpu-fanout parameter Holger Eitzenberger
2013-04-01 23:29 ` Pablo Neira Ayuso
2013-04-02 10:35 ` Holger Eitzenberger
2013-04-02 11:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402112632.GA9386@localhost \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).