netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Victor Julien <victor@inliniac.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [Ulogd2 PATCH 2/3] Lower libnfnetlink requirement to 1.0.0
Date: Fri, 5 Apr 2013 17:39:40 +0200	[thread overview]
Message-ID: <20130405153940.GC32205@localhost> (raw)
In-Reply-To: <1365172437-15042-3-git-send-email-victor@inliniac.net>

On Fri, Apr 05, 2013 at 04:33:56PM +0200, Victor Julien wrote:
> Build and run tested against 1.0.0, worked fine for me.
> 
> ---
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index a439bee..5755cf5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -48,7 +48,7 @@ regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
>  AC_SUBST([regular_CFLAGS])
>  
>  dnl Check for the right nfnetlink version
> -PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> +PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.0])

Same thing here. There was also a reason to bump the version
dependency.

There's a fix in libnfnetlink in the nlif interface.

commit 8b15e485c0d5f4a1e56b2148a34995ed1fa9e95b
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date:   Mon Aug 13 19:49:58 2012 +0200

    iftable: fix incomplete list of interfaces via nlif_query

In systems with lots of NICs, nlif_query may fail without that patch
in libnfnetlink.

Please, don't downgrade the dependencies.

  reply	other threads:[~2013-04-05 15:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 14:33 [ulogd2] lower netfilter library requirements Victor Julien
2013-04-05 14:33 ` [Ulogd2 PATCH 1/3] Remove configure check for libmnl, it is not used Victor Julien
2013-04-05 15:34   ` Pablo Neira Ayuso
2013-04-05 15:47     ` Victor Julien
2013-04-05 16:00       ` Pablo Neira Ayuso
2013-04-05 14:33 ` [Ulogd2 PATCH 2/3] Lower libnfnetlink requirement to 1.0.0 Victor Julien
2013-04-05 15:39   ` Pablo Neira Ayuso [this message]
2013-04-05 16:08     ` Victor Julien
2013-04-05 16:23       ` Pablo Neira Ayuso
2013-04-05 14:33 ` [Ulogd2 PATCH 3/3] Lower libnetfilter_conntrack requirement to 0.9.1 Victor Julien
2013-04-05 15:37   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130405153940.GC32205@localhost \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=victor@inliniac.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).