From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_nat: fix race when unloading protocol modules
Date: Thu, 11 Apr 2013 16:44:05 +0200 [thread overview]
Message-ID: <20130411144404.GA12554@macbook.localnet> (raw)
In-Reply-To: <1365690159-31122-1-git-send-email-fw@strlen.de>
On Thu, Apr 11, 2013 at 04:22:39PM +0200, Florian Westphal wrote:
> following oops was reported:
> RIP: 0010:[<ffffffffa03227f2>] [<ffffffffa03227f2>] nf_nat_cleanup_conntrack+0x42/0x70 [nf_nat]
> RSP: 0018:ffff880202c63d40 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: ffff8801ac7bec28 RCX: ffff8801d0eedbe0
> RDX: dead000000200200 RSI: 0000000000000011 RDI: ffffffffa03265b8
> [..]
> Call Trace:
> [..]
> [<ffffffffa02febed>] destroy_conntrack+0xbd/0x110 [nf_conntrack]
>
> Happens when a conntrack timeout expires right after first part
> of the nat cleanup has completed (bysrc hash removal), but before
> part 2 has completed (re-initialization of nat area).
>
> [ destroy callback tries to delete bysrc again ]
>
> Patrick suggested to just remove the affected conntracks -- the
> connections won't work properly anyway without nat transformation.
>
> So, lets do that.
>
> Reported-by: CAI Qian <caiqian@redhat.com>
> Cc: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Looks good to me.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2013-04-11 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 14:22 [PATCH] netfilter: nf_nat: fix race when unloading protocol modules Florian Westphal
2013-04-11 14:44 ` Patrick McHardy [this message]
2013-04-12 10:13 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411144404.GA12554@macbook.localnet \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).